feat: segmented storage breakdown bar with expandable Other

[elijahfriedman]

Summary

• replace per-item storage bars with one segmented bar and matching legend
• fold components beyond the eight-row budget into an expandable Other group without losing copyable paths
• resize the live menu hosting row synchronously when Other expands or collapses, capped by the existing screen-aware viewport
• keep tiny and zero-byte segments visible, aggregate overflow safely, and handle negative and Int64 boundary values
• add localized long byte-unit labels across all 21 app languages, with singular/plural selection matching the displayed rounded value
• show the overview Storage row as one compact inline total

Verification

• swift test --filter 'StorageBreakdownSegmentTests|UsageFormatterTests|StatusMenuHostedSubmenuRefreshTests|ProviderStorageFootprintTests' - 64 tests passed on exact head
• make check - passed with zero SwiftFormat or SwiftLint violations and all locale checks green
• all 21 catalogs contain the storage controls and eight long byte-unit keys; the landed Mistral keys remain intact
• swift test --filter LocalizationLanguageCatalogTests - 18 tests passed after allowing the four standard Italian singular byte-unit loanwords exposed by hosted shard 0
• whole-branch autoreview - clean, confidence 0.86; focused height/plural repair review clean, confidence 0.87
• freshly packaged app passed strict deep codesign verification and launched successfully
• contributor collapsed/expanded screenshots below verify the segmented bar, legend, Other disclosure, and compact overview row

Exact candidate: 57ac6bae60f9500d042e197fa96d90e6ebd91f0c.

Maintainer live click-through was blocked by the unchanged macOS app-data privacy prompt, which was left untouched. The test instance was stopped cleanly; no stronger live claim is made.

Screenshots

Before:

After:

[clawsweeper]

Codex review: needs changes before merge. Reviewed June 19, 2026, 2:34 AM ET / 06:34 UTC.

Summary
The PR replaces the storage breakdown rows with a segmented SwiftUI bar, an expandable Other group, long byte-unit labels, synchronous hosted-menu height resizing, localization updates, and focused tests.

Reproducibility: not applicable. this is a feature PR for a user-visible storage-menu layout rather than a bug report. The relevant evidence is source review plus inspected before/after screenshots.

Review metrics: 2 noteworthy metrics.

• Changed surface: 28 files, +637/-43. The PR spans SwiftUI menu behavior, formatter logic, tests, CHANGELOG, and localization catalogs.
• Localization catalogs: 21 catalogs changed. The new Storage controls and long byte-unit labels are user-visible across all shipped languages.

Root-cause cluster
Relationship: canonical
Canonical: #1641
Summary: This PR is the active segmented storage breakdown landing path; the earlier same-author predecessor was closed unmerged before this one continued the work.

Members:

• superseded: Feature/storage breakdown segmented bar #1640 - Closed unmerged predecessor from the same author with the same storage breakdown segmented-bar direction and no remaining discussion.

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🦞 diamond lobster ✨ media proof bonus
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

• [P2] Add an eighth distinct segment color or cap visible non-Other rows at seven.

Risk before merge

• [P1] The visible storage-menu UX replaces the existing per-item bars, so maintainers still need to accept the new presentation before merge.
• The latest GitHub check rollup I inspected still had macOS test shards queued or in progress for the PR head, so merge should wait for normal required checks.

Maintainer options:

1. Decide the mitigation before merge
   Land the segmented storage menu after maintainer UX acceptance, green final-head checks, and a small palette fix or explicit acceptance of the exact-eight duplicate color.
2. Pause or close
   Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge

• [P2] A narrow automated repair can add an eighth distinct palette color or cap visible rows at seven; maintainer UX acceptance remains separate.

Security
Cleared: The diff changes SwiftUI menu rendering, localization strings, formatter logic, tests, and CHANGELOG without adding dependencies, scripts, secrets, permissions, or code-execution paths.

Review findings

• [P3] Give the eighth visible storage segment its own color — Sources/CodexBar/StorageBreakdownMenuView.swift:60-68

Review details

Best possible solution:

Land the segmented storage menu after maintainer UX acceptance, green final-head checks, and a small palette fix or explicit acceptance of the exact-eight duplicate color.

Do we have a high-confidence way to reproduce the issue?

Not applicable; this is a feature PR for a user-visible storage-menu layout rather than a bug report. The relevant evidence is source review plus inspected before/after screenshots.

Is this the best way to solve the issue?

Yes, broadly; the patch reuses the existing StorageBreakdownMenuView and MenuHostingView paths and adds focused formatter/storage tests. Adding an eighth palette color or reducing the visible non-Other cap is the narrow remaining repair.

Full review comments:

• [P3] Give the eighth visible storage segment its own color — Sources/CodexBar/StorageBreakdownMenuView.swift:60-68
maxRows allows eight visible components, but segmentPalette only has seven colors and selection wraps by modulo. With exactly eight components, two unrelated legend rows share the same bar color; add an eighth distinct color or cap visible non-Other rows at seven.
  Confidence: 0.87

Overall correctness: patch is correct
Overall confidence: 0.86

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 88b467a17629.

Label changes

Label justifications:

• P3: This is a low-risk visible storage-menu ergonomics feature with screenshot proof and no urgent regression, security, or availability impact.
• rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🦞 diamond lobster and patch quality is 🐚 platinum hermit.
• status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (screenshot): The before/after screenshots in the PR body directly show the segmented storage menu, compact overview row, collapsed Other row, and expanded Other list.
• proof: sufficient: Contributor real behavior proof is sufficient. The before/after screenshots in the PR body directly show the segmented storage menu, compact overview row, collapsed Other row, and expanded Other list.
• proof: 📸 screenshot: Contributor real behavior proof includes screenshot evidence. The before/after screenshots in the PR body directly show the segmented storage menu, compact overview row, collapsed Other row, and expanded Other list.

Evidence reviewed

Acceptance criteria:

• [P1] swift test --filter StorageBreakdownSegmentTests.
• [P1] make check.

What I checked:

• Repository policy read: AGENTS.md was read fully; its guidance supports focused SwiftPM/source validation and avoiding live provider or Keychain-triggering checks during review. (AGENTS.md:1, 88b467a17629)
• No matching maintainer notes: The repository has .agents skills but no .agents/maintainer-notes files to apply for this PR.
• Current main still has the old storage rows: Current main uses visibleComponents, per-component progress rows, and a separate more-items label rather than a segmented bar with expandable Other. (Sources/CodexBar/StorageBreakdownMenuView.swift:46, 88b467a17629)
• PR head adds segmented storage behavior: PR head adds maxRows, a Segment model, a segment palette, overflow folding into Other, normalized segment widths, and expanded overflow rows. (Sources/CodexBar/StorageBreakdownMenuView.swift:57, 57ac6bae60f9)
• Overflow paths are preserved: The PR maps copyablePaths from all footprint components plus cleanup recommendations, so paths folded into Other remain copyable. (Sources/CodexBar/StorageBreakdownMenuView.swift:80, 57ac6bae60f9)
• Exact-eight palette ambiguity remains: maxRows allows eight visible components, but segmentPalette defines seven colors and color selection wraps by modulo, so exactly eight components reuse the first color. (Sources/CodexBar/StorageBreakdownMenuView.swift:60, 57ac6bae60f9)

Likely related people:

• fatiheminoge: Commit 5252068 introduced provider storage usage, including StorageBreakdownMenuView and ProviderStorageFootprint. (role: original provider storage feature contributor; confidence: high; commits: 5252068a1e1a; files: Sources/CodexBar/StorageBreakdownMenuView.swift, Sources/CodexBarCore/ProviderStorageFootprint.swift, Tests/CodexBarTests/ProviderStorageFootprintTests.swift)
• steipete: Recent history includes hosted submenu reuse on main and PR-head commits completing segmented storage behavior, zero-byte rendering, expansion resizing, and localization test adjustment. (role: recent adjacent owner and PR head finisher; confidence: high; commits: 7c0ed036e2e6, f1323e615df9, e2bf24fc9c58; files: Sources/CodexBar/StatusItemController+HostedSubmenus.swift, Sources/CodexBar/StorageBreakdownMenuView.swift, Tests/CodexBarTests/LocalizationLanguageCatalogTests.swift)
• soohanpark: Commit ad2a035 changed ProviderStorageFootprint publishing behavior and related tests in the data path feeding this menu. (role: recent storage-footprint contributor; confidence: medium; commits: ad2a035f6601; files: Sources/CodexBar/UsageStore+ProviderStorage.swift, Sources/CodexBarCore/ProviderStorageFootprint.swift, Tests/CodexBarTests/ProviderStorageFootprintTests.swift)
• elijahfriedman: Separate from authoring this PR, commit 2fd41ef recently changed hosted menu card resizing behavior adjacent to the expansion-height path modified here. (role: recent hosted-menu contributor; confidence: medium; commits: 2fd41efd4ac3; files: Sources/CodexBar/StatusItemController+HostedSubmenus.swift)
• LeoLin990405: Commit 4c092ce changed in-menu copy behavior after hosted-menu beachballing, touching the same storage copy-button surface. (role: recent adjacent availability contributor; confidence: medium; commits: 4c092ce344c5; files: Sources/CodexBar/StorageBreakdownMenuView.swift)

What the crustacean ranks mean

• 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
• 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
• 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
• 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
• 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
• 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
• 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works

• ClawSweeper keeps one durable marker-backed review comment per issue or PR.
• Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
• A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
• PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
• Maintainers can also comment @clawsweeper review to request a fresh review only.
• Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
• Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
• Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 67b945c990

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[elijahfriedman]

@clawsweeper re-review

[clawsweeper]

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

[elijahfriedman]

@clawsweeper re-review

[clawsweeper]

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

[steipete]

Exact-head maintainer proof for 57ac6bae60f9500d042e197fa96d90e6ebd91f0c:

• Hosted CI passed all four macOS shards, Linux x64/arm64 builds and tests, independent lint, aggregate gating, and security checks.
• 64 focused storage-segment, formatter, hosted-submenu, and provider-storage tests passed on the final head.
• make check passed with no format, lint, package, parser, release-guard, or locale findings.
• All 21 app catalogs contain the storage controls and long byte-unit keys while retaining the landed Mistral labels.
• Final whole-branch autoreview was clean, confidence 0.86; focused expansion-height/plural repair review was clean, confidence 0.87.
• The expanded Other group synchronously updates the real menu hosting row's intrinsic height and remains capped by the screen-aware viewport.
• A freshly packaged app passed strict deep codesign verification and launched successfully. Contributor collapsed/expanded screenshots verify the segmented bar, legend, disclosure, and compact overview row.
• Maintainer click-through remained blocked by the untouched macOS app-data privacy prompt, so no stronger live interaction claim is made.

Ready to land.