Support Safari, Firefox, and Edge for Xiaomi MiMo - #1350
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 10, 2026, 4:14 AM ET / 08:14 UTC. Summary Reproducibility: not applicable. as a feature PR, though source inspection confirms current main limits MiMo Auto to Chrome, Chrome Beta, and Chrome Canary while the PR expands that order. Review metrics: 3 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the curated MiMo browser-order change after maintainers accept the expanded default scope and the PR body includes redacted after-fix proof from a real supported-browser MiMo import. Do we have a high-confidence way to reproduce the issue? Not applicable as a feature PR, though source inspection confirms current main limits MiMo Auto to Chrome, Chrome Beta, and Chrome Canary while the PR expands that order. Is this the best way to solve the issue? Mostly yes: a provider-specific curated browser list is the maintainable shape and avoids the earlier full-default-order problem. It is not merge-ready until real behavior proof and maintainer acceptance of the expanded automatic cookie scope are present. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against e97bfb0db9eb. Label changesLabel changes:
Label justifications:
Evidence reviewedSecurity concerns:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee64c84b84
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /// for "Chrome-only when possible" to avoid extra browser keychain prompts. | ||
| public static var mimoCookieImportOrder: BrowserCookieImportOrder? { | ||
| #if os(macOS) | ||
| [.safari] + Browser.defaultImportOrder.filter { $0 != .safari } |
There was a problem hiding this comment.
Limit MiMo auto import to intended browsers
In macOS auto mode this now appends every entry from Browser.defaultImportOrder after Safari; that default order is already asserted to contain Firefox, so MiMo will probe Firefox (and other default browsers) even though the new docs/comment say Firefox should fall through to Manual and the repo guidance asks to avoid extra browser prompts. This can surface unexpected browser/keychain access attempts or import a MiMo session from a browser the UI says is not used; please build an explicit Safari + Chrome-variant list instead of reusing the full default order.
Useful? React with 👍 / 👎.
|
@clawsweeper re-review Follow-up for the needs proof / browser-scope feedback:
Please re-run the review against |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
Updated scope to match issue #1304 wording: main was Chrome-only; Auto now includes Safari, Chrome variants, Firefox, and Edge ( The earlier “Safari + Chrome only” title/body was written to satisfy ClawSweeper’s AGENTS.md narrow-scope suggestion, but that under-delivered on the issue request. PR title/description and @clawsweeper re-review against |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
Add bounded automatic cookie discovery for Safari, Chrome variants, Firefox, and Edge. Surface browser permission failures and defer cookie I/O to fetch time. Co-authored-by: Yuxin Qiao <Yuxin-Qiao@users.noreply.github.com>
bf213ac to
a2080db
Compare
Summary
Closes #1304.
Validation
DEVELOPER_DIR=/Applications/Xcode264.app/Contents/Developer make checkDEVELOPER_DIR=/Applications/Xcode264.app/Contents/Developer xcrun swift test --filter 'BrowserCookieOrderStatusStringTests|MiMoProviderTests'(29 tests)DEVELOPER_DIR=/Applications/Xcode264.app/Contents/Developer xcrun swift test(3,419 tests, 392 suites)origin/mainNo live browser-cookie or Keychain probe was run; permission behavior is covered with an injected cookie-loader regression.