Add native Polish localization support - #1253
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 15, 2026, 3:18 AM ET / 07:18 UTC. Summary Reproducibility: not applicable. this is a localization feature PR rather than a bug report. Current main lacks Polish, while the diff and screenshots establish the changed behavior path. Review metrics: 4 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the focused Polish localization after current-head CI passes and a maintainer or native Polish reviewer accepts the catalog quality for automatic System-language use. Do we have a high-confidence way to reproduce the issue? Not applicable; this is a localization feature PR rather than a bug report. Current main lacks Polish, while the diff and screenshots establish the changed behavior path. Is this the best way to solve the issue? Yes for implementation shape: the PR follows the existing AppLanguage, catalog, and localization-test pattern. The remaining question is product and native-language quality acceptance before exposing Polish automatically to System-language users. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 3263f0476d05. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 545c87d4ab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /* English localization for CodexBar (base/fallback) */ | ||
|
|
||
| " providers" = " providers"; | ||
| "(System)" = "(System)"; | ||
| "30d" = "30d"; | ||
| "A managed Codex login is already running. Wait for it to finish before adding " = "A managed Codex login is already running. Wait for it to finish before adding "; |
There was a problem hiding this comment.
Translate the Polish strings before enabling Polish
When users select the new Polish language, localizedBundle() will load this pl.lproj file, but the file is still mostly the English/base table (864 of 1029 entries match English, starting with the provider/login/account strings here). That makes the newly advertised Polish option render large parts of the app in English rather than Polish; translate these entries before shipping the language option.
Useful? React with 👍 / 👎.
|
@clawsweeper re-review Addressed in latest commits ( Proof (Polish selected in app)1) Menu popup (core usage card + actions)
2) General settings pane
3) Providers pane
4) Display settings pane
5) Advanced settings pane
Notes
|
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
034add6 to
d948204
Compare
f949d99 to
25ac8f2
Compare
25ac8f2 to
618ebe6
Compare
|
Rebased and updated the PR head to Completed:
Autoreview found one remaining merge blocker: 814 of 1038 Polish values are still exact English placeholders, leaving only 224 translated entries. Existing selectable non-English catalogs have roughly 990 or more translated values. This PR should stay open until the Polish catalog is substantially complete and native-quality; I am not auto-merging it in the current state. |
bb31f02 to
4a1b066
Compare
7de4618 to
292b53d
Compare
292b53d to
419273e
Compare
419273e to
88e1ee5
Compare
- Add 'language_polish' to languageKeys in LocalizationLanguageCatalogTests so the new case in AppLanguage matches the test's expected key set. - Add 'language_polish' entry to fr/nl/uk/vi lproj (the four lproj added to main after the original Polish PR was opened) so the per-catalog coverage check passes. - Add missing language_french/dutch/ukrainian/vietnamese to pl.lproj with Polish translations so pl.lproj is also covered by the test.
…talogs) After rebasing onto origin/main, the invariant test 'localized catalogs include every app language label' requires every lproj to contain every language_<X> key. Add language_japanese to pl.lproj and language_polish to ja.lproj. No-op for app behavior; only catalog parity for invariant.
88e1ee5 to
bdb5d1f
Compare





Summary
pl) as a selectable app languagepl.lproj/Localizable.stringsfor native Polish localizationlanguage_polishlabel across existing localesTesting
swift testtargets