Add native Vietnamese localization support

[Yuxin-Qiao]

Summary:

• Add Vietnamese (vi) as a native app language option.
• Add a complete vi.lproj/Localizable.strings resource file.
• Add language_vietnamese labels to the existing language packs so the language picker can display Vietnamese consistently.

Validation:

• swift test --filter PreferencesPaneSmokeTests
• Verified vi.lproj key parity with en.lproj.
• Verified placeholder and newline consistency between English and Vietnamese localization files.

[clawsweeper]

Codex review: needs maintainer review before merge. Reviewed June 7, 2026, 6:34 AM ET / 10:34 UTC.

Summary
The PR adds Vietnamese as a selectable app language, adds a full vi.lproj/Localizable.strings catalog, adds Vietnamese labels to existing catalogs, and extends localization language-label coverage.

Reproducibility: not applicable. this is a feature PR rather than a bug report. The diff and screenshots provide a high-confidence verification path for the new visible Vietnamese UI behavior.

Review metrics: 3 noteworthy metrics.

• Diff scope: 14 files, 1,133 additions, 0 deletions. The change is broad in line count because it adds a full localization catalog, but the touched surface stays within localization resources, one language enum, one test, and release notes.
• Localization catalogs: 1 catalog added, 10 existing catalogs updated. Every existing language catalog receives the Vietnamese language-picker label so the picker does not fall back inconsistently.
• Test coverage: 1 parity test added. The new test checks all .lproj catalogs for every selectable app-language label, covering the prior label-sync class of regression.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🦞 diamond lobster ✨ media proof bonus
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

• none.

Risk before merge

• [P1] This static review did not independently validate every Vietnamese translation with a native-speaker pass; screenshots prove the UI loads in Vietnamese, not full translation quality.

Maintainer options:

1. Decide the mitigation before merge
   Land the focused Vietnamese localization after normal checks and maintainer acceptance, keeping the new catalog and parity test while letting release-owned notes be adjusted by the release flow if needed.
2. Pause or close
   Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge

• No narrow ClawSweeper repair is indicated; the PR is ready for normal maintainer review and check gating.

Security
Cleared: The diff is limited to Swift localization selection, string resources, a localization test, and release notes, with no dependency, script, secret, or code-execution changes found.

Review details

Best possible solution:

Land the focused Vietnamese localization after normal checks and maintainer acceptance, keeping the new catalog and parity test while letting release-owned notes be adjusted by the release flow if needed.

Do we have a high-confidence way to reproduce the issue?

Not applicable; this is a feature PR rather than a bug report. The diff and screenshots provide a high-confidence verification path for the new visible Vietnamese UI behavior.

Is this the best way to solve the issue?

Yes; the PR follows the existing localization pattern by adding an AppLanguage case, a vi.lproj catalog, cross-catalog language labels, and focused parity coverage. The remaining decision is normal maintainer acceptance of a new native language.

AGENTS.md: found and applied where relevant.

Codex review notes: model gpt-5.5, reasoning high; reviewed against 1583d6cc1005.

Label changes

Label changes:

• add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🦞 diamond lobster and patch quality is 🐚 platinum hermit.
• add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (screenshot): The contributor posted after-change screenshots showing the localized menu and settings language picker, which is appropriate proof for this visible app-language feature.
• remove rating: 🧂 unranked krab: Current PR rating is rating: 🐚 platinum hermit, so this older rating label is no longer current.
• remove status: ⏳ waiting on author: Current PR status label is status: 👀 ready for maintainer look.

Label justifications:

• P2: This is a normal user-facing localization feature with bounded app-language-picker scope and no urgent runtime breakage.
• rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🦞 diamond lobster and patch quality is 🐚 platinum hermit.
• status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (screenshot): The contributor posted after-change screenshots showing the localized menu and settings language picker, which is appropriate proof for this visible app-language feature.
• proof: sufficient: Contributor real behavior proof is sufficient. The contributor posted after-change screenshots showing the localized menu and settings language picker, which is appropriate proof for this visible app-language feature.
• proof: 📸 screenshot: Contributor real behavior proof includes screenshot evidence. The contributor posted after-change screenshots showing the localized menu and settings language picker, which is appropriate proof for this visible app-language feature.

Evidence reviewed

What I checked:

• Repository policy read: AGENTS.md was present and read fully; its focused-test, small-change, and release/process guidance informed the localization review. (AGENTS.md:1, 1583d6cc1005)
• Current main lacks Vietnamese: On current main, AppLanguage includes system, English, Spanish, Catalan, Chinese, Portuguese, Swedish, French, Dutch, and Ukrainian, but no Vietnamese case. (Sources/CodexBar/PreferencesGeneralPane.swift:5, 1583d6cc1005)
• PR adds Vietnamese app-language routing: The PR head adds case vietnamese = "vi" and maps it to language_vietnamese, matching the existing language-picker pattern. (Sources/CodexBar/PreferencesGeneralPane.swift:17, 7a8ced8adb9a)
• PR adds Vietnamese catalog: The PR head adds a 1067-line Vietnamese Localizable.strings catalog ending with language_vietnamese = Tiếng Việt. (Sources/CodexBar/Resources/vi.lproj/Localizable.strings:1067, 7a8ced8adb9a)
• Previous quote blocker appears repaired: A static scan of the PR head Vietnamese strings found no unescaped HTML class= fragment and no lines outside the expected .strings key/value/comment shape. (Sources/CodexBar/Resources/vi.lproj/Localizable.strings, 7a8ced8adb9a)
• PR adds label parity coverage: The PR head adds a localized catalogs include every app language label test that checks every .lproj catalog for all app-language label keys, including Vietnamese. (Tests/CodexBarTests/LocalizationLanguageCatalogTests.swift:28, 7a8ced8adb9a)

Likely related people:

• Yuxin-Qiao: Recent merged main commits added French, Ukrainian, and Dutch through the same AppLanguage and .lproj resource path, and the Ukrainian commit introduced the localization language catalog test file. (role: recent localization contributor; confidence: high; commits: d3151b719e32, ae63897f3ee5, 1583d6cc1005; files: Sources/CodexBar/PreferencesGeneralPane.swift, Sources/CodexBar/Resources/fr.lproj/Localizable.strings, Sources/CodexBar/Resources/uk.lproj/Localizable.strings)
• steipete: The base AppLanguage and English resource setup are blamed to commit 723734e, and the current PR head includes a fix: complete Vietnamese localization catalog commit authored by Peter Steinberger. (role: base localization/settings owner and recent branch maintainer; confidence: medium; commits: 723734ef3422, 7a8ced8adb9a; files: Sources/CodexBar/PreferencesGeneralPane.swift, Sources/CodexBar/Resources/en.lproj/Localizable.strings, Sources/CodexBar/Resources/vi.lproj/Localizable.strings)

What the crustacean ranks mean

• 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
• 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
• 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
• 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
• 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
• 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
• 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works

• ClawSweeper keeps one durable marker-backed review comment per issue or PR.
• Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
• A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
• PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
• Maintainers can also comment @clawsweeper review to request a fresh review only.
• Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
• Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
• Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 80b5a37a91

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Escape embedded quotes in the Vietnamese strings file

When the app language is set to Vietnamese, this unescaped class="w0" attribute makes vi.lproj/Localizable.strings invalid; plutil -lint reports a missing semicolon on this line, so Foundation cannot load the table and Vietnamese lookups fall back instead of using the new translations. Escape the embedded quotes or remove the generated HTML fragment so the .strings file parses.

Useful? React with 👍 / 👎.

[Yuxin-Qiao]

Implemented and polished native Vietnamese localization based on the review feedback.

Updated UI screenshots:

@clawsweeper re-review

[clawsweeper]

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

Re-review progress:

• State: Failed
• Detail: The targeted re-review did not finish cleanly. Check the workflow run for details.
• Run: https://github.com/openclaw/clawsweeper/actions/runs/26741679552
• Updated: 2026-06-01T07:50:06.075Z

[steipete]

Merged as b442183.

Tested:

• plutil -lint Sources/CodexBar/Resources/*.lproj/Localizable.strings
• Language catalog parity scan for all AppLanguage labels in every localized catalog
• swift test --filter LocalizationLanguageCatalogTests
• swift test --filter LocalizationBundleTests
• git diff --check
• make check
• env CODEX_HOME=/tmp/codexbar-empty-codexhome-1247 swift test - full suite passed: 3334 tests in 389 suites
• /Users/steipete/Projects/agent-skills/skills/autoreview/scripts/autoreview --mode local - clean, no accepted/actionable findings

CI for exact head 7a8ced8adb9a2b1a061b392d26d292362ab70c2c:

• GitGuardian Security Checks - success
• CI / build-linux-cli (linux-arm64, ubuntu-24.04-arm) - success
• CI / build-linux-cli (linux-x64, ubuntu-24.04) - success
• CI / lint-build-test - success

Verification images: not applicable; no UI visual change in the maintainer fixup.