Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapse logic to reduce code complexity #1

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Collapse logic to reduce code complexity #1

merged 1 commit into from
Jan 31, 2023

Conversation

krassowski
Copy link

Collapse logic to reduce code complexity as explained in review of jupyterlab#489

@krassowski
Copy link
Author

@steff456

steff456
steff456 approved these changes Jan 26, 2023
View reviewed changes
Copy link
Owner

@steff456 steff456 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks mike, I'll add the changes!

@krassowski
Copy link
Author

You can just merge this PR to pull them in :)

@steff456 steff456 merged commit 8cca0f6 into steff456:collapse-menu Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steff456 steff456 steff456 approved these changes

Assignees

@krassowski krassowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krassowski @steff456