Skip to content

Test matrix#125

Merged
kostya merged 4 commits intostefanwille:masterfrom
caspiano:test-matrix
Oct 12, 2021
Merged

Test matrix#125
kostya merged 4 commits intostefanwille:masterfrom
caspiano:test-matrix

Conversation

@caspiano
Copy link
Copy Markdown
Contributor

Creates a test matrix with the range given in the shard.yml.

This was done to show an issue with type annotations introduced in the 1.2.0 release candidate.

It also looks like this has unearthed some issues against crystal versions in the >= 0.34.0, <= 0.35.1 range

@kostya
Copy link
Copy Markdown
Collaborator

kostya commented Oct 12, 2021

can you update shard.yml to >= 0.36.1, and skip older versions from testing?, also i not think nightly test needed

@caspiano
Copy link
Copy Markdown
Contributor Author

caspiano commented Oct 12, 2021

I set the nightly test because I caught a bug that would have shown up in 1.2.0 if I hadn't tested this library against nightly.
The matrix is configured such that if nightly fails, the suite will not be marked as failing.

See crystal-lang/crystal#11308

@caspiano
Copy link
Copy Markdown
Contributor Author

caspiano commented Oct 12, 2021

I've updated the version range to just >= 0.36.1.
See here for reasoning.

@kostya kostya merged commit d95e65b into stefanwille:master Oct 12, 2021
@caspiano caspiano deleted the test-matrix branch October 12, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants