Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker alpine + Node Upgrade #7

Merged
merged 3 commits into from
Jun 5, 2018

Conversation

captn3m0
Copy link
Contributor

  • Tested both with and without Docker on Node 9.11.1

Takes down the image size from 690MB to 115MB

@captn3m0
Copy link
Contributor Author

Built on Docker Cloud as captn3m0/speedtest-exporter:alpine

@captn3m0
Copy link
Contributor Author

captn3m0 commented May 5, 2018

@stefanwalther can this be merged?

captn3m0 added a commit to captn3m0/nebula that referenced this pull request May 5, 2018
@stefanwalther
Copy link
Owner

Sorry, didn't see, will give it a try and then come back to you/merge.
Thx a lot for the contribution!

@captn3m0
Copy link
Contributor Author

captn3m0 commented Jun 4, 2018

@stefanwalther reminder to take a look.

@stefanwalther stefanwalther merged commit 7d4aa59 into stefanwalther:master Jun 5, 2018
stefanwalther pushed a commit that referenced this pull request Jun 5, 2018
@stefanwalther
Copy link
Owner

Done, thx a lot!

@stefanwalther
Copy link
Owner

Seems that there is an issue ... I have a few improvements available to this repo (v2.0), which I'll try to merge ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants