find is just strange, I think we should deprecate #122
Comments
|
SG. Was a good experiment but it had cross-cutting concerns that never seemed quite right. |
|
What's the current status on this? |
|
I'm in favor of deprecating also. |
|
@stefanpenner time to deprecate, what's the process? |
rwjblue
added a commit
to rwjblue/ember.js
that referenced
this issue
Mar 1, 2017
Prior to these changes, in order to `npm link ember-source` you must run a production build of Ember. This is because of the list of files that we provide to `stew.find` (now `Funnel`) includes `ember.prod.js` and `ember.min.js`. This commit does two main things: * Remove usage of `stew.find` (and therefore remove `broccoli-stew` as a dep). It is likely that `stew.find` will be deprecated (stefanpenner/broccoli-stew#122). * Only provide the list of files that are present to the `Funnel` `files` listing. Before this change the following would throw an error: ``` git clone [email protected]:emberjs/ember.js.git ember-canary cd ember-canary yarn install ./node_modules/.bin/ember build --environment=development yarn link cd .. ember new test-app --yarn cd test-app yarn link ember-source ember s ```
|
thanks for pinging, I think we just place a warning when invoking |
|
@i've put this on my OSS queue! |
chadhietala
pushed a commit
to emberjs/ember.js
that referenced
this issue
Mar 2, 2017
Prior to these changes, in order to `npm link ember-source` you must run a production build of Ember. This is because of the list of files that we provide to `stew.find` (now `Funnel`) includes `ember.prod.js` and `ember.min.js`. This commit does two main things: * Remove usage of `stew.find` (and therefore remove `broccoli-stew` as a dep). It is likely that `stew.find` will be deprecated (stefanpenner/broccoli-stew#122). * Only provide the list of files that are present to the `Funnel` `files` listing. Before this change the following would throw an error: ``` git clone [email protected]:emberjs/ember.js.git ember-canary cd ember-canary yarn install ./node_modules/.bin/ember build --environment=development yarn link cd .. ember new test-app --yarn cd test-app yarn link ember-source ember s ``` (cherry picked from commit 1a24de8)
wycats
pushed a commit
to emberjs/ember.js
that referenced
this issue
Mar 8, 2017
Prior to these changes, in order to `npm link ember-source` you must run a production build of Ember. This is because of the list of files that we provide to `stew.find` (now `Funnel`) includes `ember.prod.js` and `ember.min.js`. This commit does two main things: * Remove usage of `stew.find` (and therefore remove `broccoli-stew` as a dep). It is likely that `stew.find` will be deprecated (stefanpenner/broccoli-stew#122). * Only provide the list of files that are present to the `Funnel` `files` listing. Before this change the following would throw an error: ``` git clone [email protected]:emberjs/ember.js.git ember-canary cd ember-canary yarn install ./node_modules/.bin/ember build --environment=development yarn link cd .. ember new test-app --yarn cd test-app yarn link ember-source ember s ``` (cherry picked from commit 1a24de8)
13 tasks
|
@locks how looks that queue? |
|
@stefanpenner getting round to it atm |
stefanpenner
added a commit
that referenced
this issue
Jun 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In nearly all cases,
stew.findis better served by just usingFunnel. I think it was a good experiment. We should confirm the above, and then find a good path forward.The text was updated successfully, but these errors were encountered: