Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to node20 #70

Merged
merged 2 commits into from
Feb 1, 2024
Merged

feat: update to node20 #70

merged 2 commits into from
Feb 1, 2024

Conversation

joshjohanning
Copy link
Contributor

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: stefanbuck/github-issue-parser@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

😄

@gr2m
Copy link
Collaborator

gr2m commented Feb 1, 2024

Actually, can you please update https://github.com/stefanbuck/github-issue-parser/blob/main/.github/workflows/ci.yml to setup Node 20 so that the tests match the runtime?

@gr2m gr2m merged commit 2ac1a18 into stefanbuck:main Feb 1, 2024
1 check passed
@joshjohanning
Copy link
Contributor Author

🙇 thank you @gr2m!

@joshjohanning
Copy link
Contributor Author

@gr2m oh I just noticed the npx semantic-release failed 😢

Did I forget to bump a version somewhere?

Copy link

github-actions bot commented Feb 2, 2024

🎉 This PR is included in version 3.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@gr2m
Copy link
Collaborator

gr2m commented Feb 2, 2024

No the error was unrelated, it looks like @stefanbuck created the prior 3.0.1 release manually, and the tag was not assigned to the master commit history. I resolved that and rerun the failed semantic-release build, now it works again

@joshjohanning
Copy link
Contributor Author

joshjohanning commented Feb 2, 2024

Woot woot thanks @gr2m! 🎉

For fun I just tried @3.0.1 - it looks like it's broken, so something might need to be re-created with that tag still :(

image

@gr2m
Copy link
Collaborator

gr2m commented Feb 2, 2024

it's not worth fixing

@joshjohanning
Copy link
Contributor Author

joshjohanning commented Feb 2, 2024

I feel like you should delete the tag, then, since if one cannot use it for Actions anyway 🤷

I just ran into a scenario, ironically, where we couldn't use node20 on the host machine so we were just rolling back to an older version 😄 @v2.0.6 worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants