-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add issue-body default #47
feat: add issue-body default #47
Conversation
Does this mean |
Nice, yeah @lemeurherve - I updated the readme accordingly. @gr2m / @stefanbuck , take a look at the readme and see if that's how you want it presented. |
Co-authored-by: Hervé Le Meur <[email protected]>
template-path: .github/ISSUE_TEMPLATE/bug-report.yml | ||
``` | ||
|
||
The text to be parsed can be set explicitly using `issue-body` input, otherwise it can be left to use the default value of `${{ github.event.issue.body }}`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lemeurherve @gr2m , what do we think about this line?
I originally wrote it longer, but cut it down for brevity, and people don't really need to see the historical references here?
Originally wrote:
In version 3.0.0, new input for
issue-body
is added to mitigate script injection attacks (see: #42). Version 3.0.1 defaultedissue-body
to${{ github.event.issue.body }}
for convenience (see: #47). The text to be parsed can be set explicitly usingissue-body
input, otherwise it can be left to use the default value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say it's great, we can iterate on it later, I'd get this PR merged
Amazing! It's really awesome to see you all to care enough about this little project to spend your time improving it. Thank you ❤️ |
For some odd reason the release pipeline was using an older commit as a baseline and this resulted in another 3.0.0 release ergo the pipeline failed with |
I had a quick glance but don't know what the reason might be. I gotta go for today, but could you file an issue and assign it to me please? I'll have a look tomorrow |
I had this browser tab still open for some reason, so I created the issue 👌 ☝️ |
closes #46
🎉