Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose between popup, sidebar and window #18

Closed
bannmann opened this issue Oct 6, 2019 · 7 comments
Closed

Choose between popup, sidebar and window #18

bannmann opened this issue Oct 6, 2019 · 7 comments

Comments

@bannmann
Copy link

bannmann commented Oct 6, 2019

Instead of opening the extension in a popup, it should also be possible to open it in a sidebar or its own window. Please let the user choose the default mode to use when clicking the toolbar button in the extension options.

@mastef
Copy link
Contributor

mastef commented Oct 7, 2019

@bannmann I could make the extension open in a new window or as popup by default based on a setting. There is currently no easy way to open it as a side bar.

@mastef
Copy link
Contributor

mastef commented Oct 28, 2019

Ok @bannmann this should be now live with the latest 5.0.8 version. It was added in this commit 055f5f2

It's already live in the Mozilla Add-Ons store. Chrome Webstore should take a few more days as they flag nowadays everything for a review.

@mastef mastef closed this as completed Oct 28, 2019
@bannmann
Copy link
Author

Thanks a lot for implementing this, it works great!

@mastef
Copy link
Contributor

mastef commented Oct 31, 2019

@bannmann there was an issue with the new page, sometimes clicking on the icon wouldn't properly switch to it. That should be now resolved in 5.1.0

Anything else I can do for you to get that last 5th star? 😄

@bannmann
Copy link
Author

Anything else I can do for you to get that last 5th star? 😄

LOL, thanks for reminding me to update my review. You earned it :-)

@keeganwitt
Copy link

Came across this while looking to see if someone had already asked for the sidebar feature: I don't see the option to display in sidebar. Looking at the commit, it looks like that wasn't included. Should I open a separate issue for this?

@mastef
Copy link
Contributor

mastef commented Mar 10, 2020

@keeganwitt yes please, right now there is no sidebar here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants