fix: description on readonly boards #1674
Conversation
without this, you cannot select text, not interact with link etc.
| binding.descriptionEditor.setEnabled(false); | ||
| binding.descriptionEditorWrapper.setVisibility(GONE); | ||
| binding.descriptionViewer.setEnabled(false); | ||
| binding.descriptionViewer.setEnabled(true); |
There was a problem hiding this comment.
This change is not necessary to view the description, but it seems mandatory to interact with it (links, selection...)
| @@ -123,7 +123,7 @@ | |||
| android:textIsSelectable="true" | |||
| android:textSize="@dimen/font_size_description" | |||
| android:translationY="1dp" | |||
| android:visibility="gone" /> | |||
| android:visibility="visible" /> | |||
There was a problem hiding this comment.
nothing works without this
|
Thank you for the contribution! I'm currently on vacation and will try to review the changes after Sept 25th. |
|
@stefan-niedermann sorry to bump you again, but I'd love to be able to use the app with read-only shared boards again, hence I kindly ask you if you're able to review and merge this soon? |
|
@Ornanovitch Sorry for the delay, @stefan-niedermann is quite busy right now, life hits hard at a certain age. Feel free to bump every here and then, but I guess he'll review it as soon as he can. You're not have been forgotten, i promise! |
|
Thanks @desperateCoder I really appreciate the feedback! |
|
Yes, I'm very sorry for the delay, you haven't been forgotten though. |
|
@Ornanovitch thank you very much for your contribution. I am very sorry for the long delay, but in the end the changes are in the |
|
Thanks a lot! I'm so glad :) |
After many attempts, I was finally able to make it! Tested with a prod server, with and without readonly boards, everything works as expected :)
But I must admit I am not fully confident with the code, I never tried to play with java code before, so I don't even understand completely why those peace of code were missing...
I'd love to have your feedbacks @stefan-niedermann