Minify CSS before writing the bundles. #348
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #88.
Instead of minifying each css node individually, this PR changes steal-tools to minify the concatenated bundle before writing. I tested this branch in my current app and got some interesting numbers:
652K dist/bundles/bundle-a.css
268K dist/bundles/bundle-b.css
192K dist/bundles/bundle-a-b.css
440K dist/bundles/bundle-a.css
196K dist/bundles/bundle-b.css
192K dist/bundles/bundle-a-b.css
There is some noise in the
write_bundles
file b/c I made some changes to the indentation, here is the interesting diff 8c3da0e.