feat: add `blas/ext/last-index-of` #7665

headlessNode · 2025-07-15T08:06:26Z

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

task: lint_filenames status: passed
task: lint_editorconfig status: passed
task: lint_markdown status: passed
task: lint_package_json status: passed
task: lint_repl_help status: passed
task: lint_javascript_src status: passed
task: lint_javascript_cli status: na
task: lint_javascript_examples status: passed
task: lint_javascript_tests status: passed
task: lint_javascript_benchmarks status: passed
task: lint_python status: na
task: lint_r status: na
task: lint_c_src status: na
task: lint_c_examples status: na
task: lint_c_benchmarks status: na
task: lint_c_tests_fixtures status: na
task: lint_shell status: na
task: lint_typescript_declarations status: passed
task: lint_typescript_tests status: passed
task: lint_license_headers status: passed ---

Progreses #2656.

Description

What is the purpose of this pull request?

This pull request:

add blas/ext/last-index-of

Related Issues

Does this pull request have any related issues?

This pull request:

progresses [RFC]: achieve ndarray API parity with built-in JavaScript arrays #2656

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

stdlib-bot · 2025-07-15T08:08:08Z

Coverage Report

Package	Statements	Branches	Functions	Lines
blas/ext/last-index-of	$\color{red}666/670$ $\color{green}+99.40\%$	$\color{red}77/78$ $\color{green}+98.72\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{red}666/670$ $\color{green}+99.40\%$

The above coverage report was generated for the changes in this PR.

lib/node_modules/@stdlib/blas/ext/last-index-of/README.md

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

kgryte · 2025-07-23T02:32:31Z

@headlessNode You'll want to make similar changes as done in #7565 in this PR.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

headlessNode · 2025-07-23T17:43:18Z

@kgryte done

lib/node_modules/@stdlib/blas/ext/last-index-of/test/test.assign.js

lib/node_modules/@stdlib/blas/ext/last-index-of/lib/assign.js

kgryte

Left an initial review.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

Signed-off-by: Muhammad Haris <[email protected]>

lib/node_modules/@stdlib/blas/ext/last-index-of/lib/assign.js

Signed-off-by: Muhammad Haris <[email protected]>

Signed-off-by: Athan <[email protected]>

lib/node_modules/@stdlib/blas/ext/last-index-of/lib/assign.js

Signed-off-by: Muhammad Haris <[email protected]>

lib/node_modules/@stdlib/blas/ext/last-index-of/lib/main.js

Signed-off-by: Muhammad Haris <[email protected]>

lib/node_modules/@stdlib/blas/ext/last-index-of/lib/main.js

Signed-off-by: Athan <[email protected]>

headlessNode · 2025-09-08T07:13:58Z

🫣

lib/node_modules/@stdlib/blas/ext/last-index-of/lib/main.js

Signed-off-by: Athan <[email protected]>

lib/node_modules/@stdlib/blas/ext/last-index-of/test/test.assign.js

Signed-off-by: Athan <[email protected]>

lib/node_modules/@stdlib/blas/ext/last-index-of/test/test.assign.js

Signed-off-by: Athan <[email protected]>

lib/node_modules/@stdlib/blas/ext/last-index-of/test/test.main.js

Signed-off-by: Athan <[email protected]>

lib/node_modules/@stdlib/blas/ext/last-index-of/test/test.main.js

Signed-off-by: Athan <[email protected]>

kgryte

LGTM after clean-up. I also went ahead and incorporated some of the test changes in index-of.

stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Jul 15, 2025

headlessNode added Feature Issue or pull request for adding a new feature. GSoC Google Summer of Code. gsoc: 2025 Google Summer of Code (2025). labels Jul 15, 2025

kgryte reviewed Jul 15, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/last-index-of/README.md Outdated Show resolved Hide resolved

headlessNode marked this pull request as ready for review July 17, 2025 04:59

stdlib-bot added the Needs Review A pull request which needs code review. label Jul 17, 2025

headlessNode requested a review from kgryte July 17, 2025 04:59

headlessNode mentioned this pull request Jul 21, 2025

Weekly Standup (2025-07-21) stdlib-js/google-summer-of-code#163

Closed

kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jul 23, 2025

headlessNode added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Aug 5, 2025

kgryte removed the Needs Review A pull request which needs code review. label Aug 9, 2025

kgryte reviewed Aug 10, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/last-index-of/test/test.assign.js Show resolved Hide resolved

kgryte reviewed Aug 10, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/last-index-of/lib/assign.js Outdated Show resolved Hide resolved

kgryte requested changes Aug 10, 2025

View reviewed changes

kgryte added the Needs Changes Pull request which needs changes before being merged. label Aug 10, 2025

headlessNode added 6 commits September 4, 2025 11:23

Merge branch 'stdlib-js:develop' into top-last-index-of

dac0781

fix: parameter description

9a16c48

Signed-off-by: Muhammad Haris <[email protected]>

kgryte reviewed Sep 8, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/last-index-of/lib/assign.js Outdated Show resolved Hide resolved

headlessNode and others added 2 commits September 8, 2025 12:08

fix: parameter description

ecc61dd

Signed-off-by: Muhammad Haris <[email protected]>

refactor: avoid unnecessarily calling hasOwnProp

2a9750e

Signed-off-by: Athan <[email protected]>

headlessNode commented Sep 8, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/last-index-of/lib/assign.js Outdated Show resolved Hide resolved

fix: parameter type description

2fcdd1d

Signed-off-by: Muhammad Haris <[email protected]>

headlessNode commented Sep 8, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/last-index-of/lib/main.js Outdated Show resolved Hide resolved

fix: parameter type description

8f435cf

Signed-off-by: Muhammad Haris <[email protected]>

kgryte reviewed Sep 8, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/last-index-of/lib/main.js Outdated Show resolved Hide resolved

docs: document default value

6b09f69

Signed-off-by: Athan <[email protected]>

kgryte reviewed Sep 8, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/last-index-of/lib/main.js Outdated Show resolved Hide resolved

fix: avoid repeatedly calling hasOwnProp when we don't need to

c637cf7

Signed-off-by: Athan <[email protected]>

kgryte reviewed Sep 8, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/last-index-of/test/test.assign.js Outdated Show resolved Hide resolved

kgryte reviewed Sep 8, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/last-index-of/test/test.assign.js Outdated Show resolved Hide resolved

test: fix test

7c3fb16

Signed-off-by: Athan <[email protected]>

kgryte reviewed Sep 8, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/last-index-of/test/test.assign.js Outdated Show resolved Hide resolved

kgryte added 2 commits September 8, 2025 00:23

test: remove dupe test

a189559

Signed-off-by: Athan <[email protected]>

test: fix descriptions and clean-up

431cae7

Signed-off-by: Athan <[email protected]>

kgryte reviewed Sep 8, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/last-index-of/test/test.main.js Outdated Show resolved Hide resolved

test: fix strides

46dc2ac

Signed-off-by: Athan <[email protected]>

kgryte reviewed Sep 8, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/last-index-of/test/test.main.js Outdated Show resolved Hide resolved

kgryte reviewed Sep 8, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/last-index-of/test/test.main.js Outdated Show resolved Hide resolved

kgryte added 3 commits September 8, 2025 01:31

test: fix expected value

a34a8b9

Signed-off-by: Athan <[email protected]>

test: fix expected value

4feace6

Signed-off-by: Athan <[email protected]>

test: update test descriptions

ef2400a

Signed-off-by: Athan <[email protected]>

kgryte approved these changes Sep 8, 2025

View reviewed changes

kgryte removed the Needs Review A pull request which needs code review. label Sep 8, 2025

kgryte merged commit 8811beb into stdlib-js:develop Sep 8, 2025
12 checks passed

headlessNode deleted the top-last-index-of branch September 8, 2025 15:37

Uh oh!

feat: add blas/ext/last-index-of #7665

feat: add blas/ext/last-index-of #7665

Uh oh!

Conversation

headlessNode commented Jul 15, 2025 • edited by kgryte Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Uh oh!

kgryte commented Jul 23, 2025

Uh oh!

headlessNode commented Jul 23, 2025

Uh oh!

Uh oh!

Uh oh!

kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

headlessNode commented Sep 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: add `blas/ext/last-index-of` #7665

feat: add `blas/ext/last-index-of` #7665

headlessNode commented Jul 15, 2025 •

edited by kgryte

Loading

stdlib-bot commented Jul 15, 2025 •

edited

Loading