Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add C implementation for math/base/special/gamma #2504

Merged
merged 6 commits into from
Jul 14, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Jul 4, 2024

Description

What is the purpose of this pull request?

This pull request:

double stdlib_base_gamma( const double x );

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Jul 4, 2024
Signed-off-by: GUNJ JOSHI <[email protected]>
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good, once the changes are done this will be ready to merge. Also the above changes are minor, I am not exactly sure which has higher precision but I think the suggested one has. Here is my discussion with chatGPT, https://chatgpt.com/share/d247d6fe-6321-49b7-a469-a92d0ab38b18

@kgryte kgryte requested a review from Planeshifter July 14, 2024 01:01
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's land this! 🚀

@Planeshifter Planeshifter merged commit 35af244 into stdlib-js:develop Jul 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants