feat: add math/base/special/acscf
#2111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgryte
reviewed
Apr 2, 2024
Signed-off-by: GUNJ JOSHI <[email protected]>
kgryte
reviewed
Apr 2, 2024
kgryte
reviewed
Apr 2, 2024
kgryte
reviewed
Apr 2, 2024
lib/node_modules/@stdlib/math/base/special/acscf/benchmark/c/native/benchmark.c
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Apr 2, 2024
Signed-off-by: Athan <[email protected]>
kgryte
requested changes
Apr 2, 2024
Member
kgryte
left a comment
kgryte
left a comment
There was a problem hiding this comment.
This is looking good. Just a few small changes and should be ready for merge.
kgryte
added
Feature
kgryte
reviewed
Apr 2, 2024
lib/node_modules/@stdlib/math/base/special/acscf/benchmark/c/native/benchmark.c
Outdated
Show resolved
Hide resolved
…ative/benchmark.c Co-authored-by: Athan <[email protected]> Signed-off-by: GUNJ JOSHI <[email protected]>
kgryte
approved these changes
Apr 3, 2024
Member
kgryte
left a comment
kgryte
left a comment
There was a problem hiding this comment.
LGTM. Thanks for working on this, @gunjjoshi!
kgryte
removed
the
Needs Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2109.
Description
This pull request:
math/base/special/acscf, which is the single-precision equivalent formath/base/special/acsc.Related Issues
This pull request:
math/base/special/acscf#2109.Questions
No.
Other
Test coverage report:
Checklist
@stdlib-js/reviewers