Fix ansible-lint rule violations

.ansible-lint

@@ -1,2 +1,3 @@
+---
 skip_list:
-  - '303'
+  - "303"

.config/ansible-lint.yml

@@ -1,4 +1,4 @@
 ---
 skip_list:
-  - '303'
+  - "303"
   - experimental

.markdownlint.yml

@@ -1,4 +1,4 @@
 ---
-"MD013": false  # line-length
-"MD014": false  # show commands output
-"MD041": false  # first line should be heading (build status image)
+MD013: false # line-length
+MD014: false # show commands output
+MD041: false # first line should be heading (build status image)

galaxy.yml

@@ -17,7 +17,6 @@ tags:
   - landscape
 
 dependencies: {}
-
 repository: https://github.com/stdevel/ansible-collection-landscape
 documentation: https://github.com/stdevel/ansible-collection-landscape/blob/main/README.md
 homepage: https://github.com/stdevel/ansible-collection-landscape

meta/runtime.yml

@@ -1,5 +1,5 @@
 ---
-requires_ansible: '>=2.9.10'
+requires_ansible: ">=2.9.10"
 
 # Content that Ansible needs to load from another location or that has
 # been deprecated/removed

roles/client/.markdownlint.yml

@@ -1,4 +1,4 @@
 ---
-"MD013": false  # line-length
-"MD014": false  # show commands output
-"MD041": false  # first line should be heading (build status image)
+MD013: false # line-length
+MD014: false # show commands output
+MD041: false # first line should be heading (build status image)

roles/client/molecule/default/converge.yml

@@ -6,16 +6,16 @@
     - name: Set hosts entry for local Landscape server
       ansible.builtin.lineinfile:
         path: /etc/hosts
-        line: '192.168.124.106 landscape-server-2310'
+        line: 192.168.124.106 landscape-server-2310
 
     - name: Upload Landscape SSL certificate
       ansible.builtin.copy:
         src: landscape.pem
         dest: /etc/landscape/landscape_server.pem
         owner: root
         group: root
-        mode: '0644'
+        mode: "0644"
 
   roles:
     - role: stdevel.landscape.client
-      client_landscape_server: 'landscape-server-2310'
+      client_landscape_server: landscape-server-2310

roles/client/molecule/default/molecule.yml

@@ -11,6 +11,6 @@ provisioner:
 verifier:
   name: testinfra
 lint: |
-    yamllint .
-    ansible-lint
-    flake8
+  yamllint .
+  ansible-lint
+  flake8

roles/client/tasks/facts.yml

@@ -1,41 +1,41 @@
 ---
 - name: Set SSL certificate (if set)
   ansible.builtin.set_fact:
-    register_parameter_ssl: "--ssl-public-key {{ client_landscape_ssl }}"
+    register_parameter_ssl: --ssl-public-key {{ client_landscape_ssl }}
   when: client_landscape_ssl is defined
 
 - name: Set account name (if set)
   ansible.builtin.set_fact:
-    register_parameter_tags: "--tags {{ client_tags }}"
+    register_parameter_tags: --tags {{ client_tags }}
   when: client_tags is defined
 - name: Set account name (if not set)
   ansible.builtin.set_fact:
-    register_parameter_tags: ''
+    register_parameter_tags: ""
   when: client_tags is undefined
 
 - name: Set registration key (if set)
   ansible.builtin.set_fact:
-    register_parameter_key: "--registration-key {{ client_registration_key }}"
+    register_parameter_key: --registration-key {{ client_registration_key }}
   when: client_registration_key is defined
 - name: Set registration key (if not set)
   ansible.builtin.set_fact:
-    register_parameter_key: ''
+    register_parameter_key: ""
   when: client_registration_key is undefined
 
 - name: Set computer title (if set)
   ansible.builtin.set_fact:
-    register_parameter_title: "--computer-title '{{ client_computer_title }}'"
+    register_parameter_title: --computer-title '{{ client_computer_title }}'
   when: client_computer_title is defined
 - name: Set computer title (if not set)
   ansible.builtin.set_fact:
-    register_parameter_title: "--computer-title '{{ ansible_fqdn }}'"
+    register_parameter_title: --computer-title '{{ ansible_fqdn }}'
   when: client_computer_title is undefined
 
 - name: Set account name (if set)
   ansible.builtin.set_fact:
-    register_parameter_account: "--account-name {{ client_account_name }}"
+    register_parameter_account: --account-name {{ client_account_name }}
   when: client_account_name is defined
 - name: Set account name (if not set)
   ansible.builtin.set_fact:
-    register_parameter_account: ''
+    register_parameter_account: ""
   when: client_account_name is undefined

roles/client/tasks/main.yml

@@ -8,7 +8,8 @@
   ansible.builtin.include_tasks: facts.yml
 
 - name: Register system
-  ansible.builtin.command: "landscape-config {{ register_parameter_ssl }} {{ register_parameter_tags }} {{ register_parameter_key }} {{ register_parameter_title }} {{ register_parameter_account }} --url https://{{ client_landscape_server }}/message-system --ping-url http://{{ client_landscape_server }}/ping --silent"
+  ansible.builtin.command: landscape-config {{ register_parameter_ssl }} {{ register_parameter_tags }} {{ register_parameter_key }} {{ register_parameter_title }}
+    {{ register_parameter_account }} --url https://{{ client_landscape_server }}/message-system --ping-url http://{{ client_landscape_server }}/ping --silent
   args:
     creates: /var/lib/landscape/client/manager.database
   become: true

roles/server/defaults/main.yml

@@ -1,3 +1,3 @@
 ---
 # package configuration
-server_version: '24.04'
+server_version: "24.04"

roles/server/meta/main.yml

@@ -1,11 +1,12 @@
+---
 galaxy_info:
   namespace: stdevel
   role_name: server
   author: Christian Stankowic
   description: Installs Ubuntu Landscape
   license: GPL-3.0-only
 
-  min_ansible_version: '2.9'
+  min_ansible_version: "2.9"
 
   platforms:
     - name: Ubuntu

roles/server/molecule/default/converge.yml

@@ -3,10 +3,10 @@
   hosts: landscape-server-2303
   roles:
     - role: server
-      server_version: '23.03'
+      server_version: "23.03"
 
 - name: Converge
   hosts: landscape-server-2404
   roles:
     - role: server
-      server_version: '24.04'
+      server_version: "24.04"

roles/server/molecule/default/molecule.yml

@@ -13,6 +13,6 @@ provisioner:
 verifier:
   name: testinfra
 lint: |
-    yamllint .
-    ansible-lint
-    flake8
+  yamllint .
+  ansible-lint
+  flake8

roles/server/tasks/main.yml

@@ -4,10 +4,10 @@
   vars:
     params:
       files:
-        - '{{ server_version }}.yml'
+        - "{{ server_version }}.yml"
         - main.yml
       paths:
-        - 'vars'
+        - vars
 
 - name: Include check tasks
   ansible.builtin.include_tasks: check.yml

roles/server/vars/main.yml

@@ -1,4 +1,4 @@
 ---
-server_ppa: "ppa:landscape/self-hosted-{{ server_version }}"
+server_ppa: ppa:landscape/self-hosted-{{ server_version }}
 server_packages:
   - landscape-server-quickstart

roles/storage/.markdownlint.yml

@@ -1,4 +1,4 @@
 ---
-"MD013": false  # line-length
-"MD014": false  # show commands output
-"MD041": false  # first line should be heading (build status image)
+MD013: false # line-length
+MD014: false # show commands output
+MD041: false # first line should be heading (build status image)

roles/storage/molecule/default/molecule.yml

@@ -13,6 +13,6 @@ provisioner:
 verifier:
   name: testinfra
 lint: |
-    yamllint .
-    ansible-lint
-    flake8
+  yamllint .
+  ansible-lint
+  flake8

roles/storage/tasks/main.yml

@@ -24,12 +24,12 @@
     - name: Create file systems # noqa: args[module]
       community.general.filesystem:
         fstype: "{{ item.type }}"
-        dev: "/dev/mapper/{{ storage_vg }}-{{ item.name }}"
+        dev: /dev/mapper/{{ storage_vg }}-{{ item.name }}
       loop: "{{ storage_filesystems }}"
     - name: Create mount points
       ansible.posix.mount:
         path: "{{ item.mountpoint }}"
-        src: "/dev/mapper/{{ storage_vg }}-{{ item.name }}"
+        src: /dev/mapper/{{ storage_vg }}-{{ item.name }}
         fstype: "{{ item.type }}"
         opts: auto
         state: mounted