fix: dont add when helmetdata already has same instance #176
+8
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
king-of-emotion
force-pushed
the
not-add-when-already-has-same-instance
branch
from
7a72ceb to
82c6bbb
Compare
king-of-emotion
changed the title
|
@staylor please check this pull request. |
Closed
|
This will also address issues brought up in #213 NextJS apps will be able to use this package after this PR has been merged. Please bump this in priority. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use react-helmet-async like https://github.com/staylor/react-helmet-async#usage-without-context example, but every time I access the website that has Helmet Component, helmetData add same instance and not remove.
Dispatcher class has componentWillUnmount, but it is not called probably because this class render method return null.
So, I want to check the helmetData when add the instance that helmetData already has or not.
sorry for my poor english.