Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#22111] fix: disabled bridge assets effect other list #22204

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

mohsen-ghafouri
Copy link
Contributor

fixes #22111

Summary

Unsupported bridge assets appear as disabled on swap pages when "swap" tapped on main wallet page

Testing notes

"send" also was effected by disabled bridge assets. please check that too.

Areas that may be impacted

Select Asset list in "swap", "send" and "bridge"

Steps to test

  1. Go to the wallet main page.
  2. Long-tap on an unsupported asset and select Bridge.
  3. Navigate to the Bridge Setup page.
  4. Either perform the transaction or go back to the wallet main page.
  5. Tap "Swap" button on the main wallet page
  6. Observe the following pages:
  • Select Asset
  • Assets to Receive
  • Assets to Pay

Result

Simulator.Screen.Recording.-.iPhone.13.-.2025-02-27.at.18.02.50.mp4

status: ready

@mohsen-ghafouri mohsen-ghafouri added the wallet-core Issues for mobile wallet team label Feb 27, 2025
@mohsen-ghafouri mohsen-ghafouri self-assigned this Feb 27, 2025
@status-im-auto
Copy link
Member

status-im-auto commented Feb 27, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ed9dbe9 #1 2025-02-27 15:18:04 ~5 min tests 📄log
✔️ ed9dbe9 #1 2025-02-27 15:20:21 ~7 min android 🤖apk 📲
✔️ ed9dbe9 #1 2025-02-27 15:20:37 ~7 min android-e2e 🤖apk 📲
✔️ ed9dbe9 #1 2025-02-27 15:31:34 ~18 min ios 📱ipa 📲
✔️ 92526be #2 2025-03-04 09:40:24 ~5 min tests 📄log
✔️ 92526be #2 2025-03-04 09:44:33 ~9 min android-e2e 🤖apk 📲
✔️ 92526be #2 2025-03-04 09:44:48 ~9 min android 🤖apk 📲
✔️ 92526be #2 2025-03-04 09:46:47 ~11 min ios 📱ipa 📲

@mohsen-ghafouri mohsen-ghafouri force-pushed the fix/disabled-swap-assets branch from ed9dbe9 to 92526be Compare March 4, 2025 09:34
@mohsen-ghafouri mohsen-ghafouri requested a review from vkjr March 4, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wallet-core Issues for mobile wallet team
Projects
Status: REVIEW
Development

Successfully merging this pull request may close these issues.

Unsupported bridge assets appear as disabled on swap pages when "swap" tapped on main wallet page
4 participants