Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#17497] fix: Unexpected lines are shown in the chat #17702

Closed
wants to merge 1 commit into from

Conversation

mohsen-ghafouri
Copy link
Contributor

fixes #17497

I discovered that the issue is connected to the scale-y property. We implemented it this way because of an open issue in React Native. The only workaround I've found so far is to increase the scale by an additional 0.02 to eliminate those lines.

Platforms

  • Android

Steps to test

  1. Open any chat
  2. Sent at least 4-5 messages
  3. Check the chat

Before and after screenshots comparison

Before

After

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Oct 20, 2023

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9e278fe #1 2023-10-20 16:03:29 ~5 min android 🤖apk 📲
✔️ 9e278fe #1 2023-10-20 16:05:35 ~8 min android-e2e 🤖apk 📲
✔️ 9e278fe #1 2023-10-20 16:07:12 ~9 min ios 📱ipa 📲
✔️ 9e278fe #1 2023-10-20 16:07:27 ~9 min tests 📄log

@Parveshdhull
Copy link
Member

hi @mohsen-ghafouri, nice finding 👏
btw, we are removing use of scale-y in #17241

@mohsen-ghafouri
Copy link
Contributor Author

Awesome @Parveshdhull , so it's up to @status-im/mobile-qa team to go with this temporary solution until we upgrade to RN-0.72 or wait for that PR

@Parveshdhull
Copy link
Member

Awesome @Parveshdhull , so it's up to @status-im/mobile-qa team to go with this temporary solution until we upgrade to RN-0.72 or wait for that PR

probably better to wait for the PR, as we are changing scale here it might affect design feedback.

@mohsen-ghafouri
Copy link
Contributor Author

@Parveshdhull yes i agree, if we will have that PR in next release it's better to wait for it. i will double check with guys and probably will close this PR

@mohsen-ghafouri
Copy link
Contributor Author

closed as the issue will fix in #17241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

[Android] Unexpected lines are shown in the chat
3 participants