-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Not enough native balance, token ETH, chain id <chainId>" Toast shown when insufficient ETH to cover the fee on send page #21253
Comments
@VolodLytvynenko @shivekkhurana so here we should just hide the toast for this error? What should we do in case of other router errors i.e. which ones we should show and which ones ignore? e.g.
|
@xAlisher, could you take a look at this question? Perhaps some additional validation should be added in the Figma. Currently, we only have a Figma design for: I believe the case 'No positive balance' is impossible to reach on the client. For other cases: 'Not enough token balance, token: %s, chainId: %d' should we just show something went wrong as described here ? |
@clauxx Could you please provide a more detailed explanation of the validations and correct me if I'm misunderstanding anything:
cc: @xAlisher |
|
@VolodLytvynenko @xAlisher yeah I think this would be best. I don't see any toasts error toast in the design, we just show "No routes found" and "Try again" button, so I think it would make sense to not show error toasts in the send modal at all. WDYT? |
@VolodLytvynenko @xAlisher @clauxx I'd suggest to postpone the handling of toast error, wdyt? |
Agree with @churik . A few toast with errors will disappear after implementing new sending flow |
sounds good to me 👍 |
Follow up for #21235
Steps:
Actual Result:
A toast message is displayed: "Not enough native balance, token ETH, chain id ."
Expected Result:
The toast message is not shown
Devices:
The text was updated successfully, but these errors were encountered: