use trim() to remove newlines when reading VERSION

[jakubgs]

Fix for failing nightly:
https://jenkins.status.im/job/status-react/job/nightly/405/
With:

+ plutil -replace CFBundleShortVersionString -string 0.9.19
No files specified.
plutil: [command_option] [other_options] file...
...

[rasom]

apk uploaded to https://i.diawi.com/TfLEEt for branch PR-4457

Install - Diawi - Development and In-house Apps Wireless Installation

[rasom]

ipa uploaded to https://i.diawi.com/EeBe5f for branch PR-4457

Install - Diawi - Development and In-house Apps Wireless Installation

[statustestbot]

75% of end-end tests have passed

Total executed tests: 28
Failed tests: 7
Passed tests: 21

Failed tests (7)

Click to expand

1. test_send_transaction_from_daap

Scrolling down to SimpleDAppButton Looking for SimpleDAppButton E selenium.common.exceptions.NoSuchElementException: Message: 'SimpleDAppButton' is not found on screen, using: 'xpath://*[@text="Simple Dapp"]' Device sessions: Device 1

2. test_faucet_console_command

Tap on SendMessageButton Looking for full text: 'Faucet request has been received' E Failed: Message with text "Faucet request has been received" was not received Device sessions: Device 1

3. test_username_and_profile_picture_in_chats

Tap on ChatElement Looking for AddToContacts E selenium.common.exceptions.NoSuchElementException: Message: 'AddToContacts' is not found on screen, using: 'accessibility id:add-to-contacts-button' Device sessions: Device 1 Device 2

4. test_contact_profile_view

Looking for CreateAccountButton E selenium.common.exceptions.NoSuchElementException: Message: 'CreateAccountButton' is not found on screen, using: 'xpath://android.widget.TextView[@text='CREATE ACCOUNT' or @text='CREATE NEW ACCOUNT']' Device sessions: Device 1

5. test_public_chat

Wait for PlusButton Looking for an element by text: 'diyyhnc' E Failed: Message '😼' was received but username is 'Wild Kindhearted Wildebeast' instead of user_525144258. Message 'message with emoji 🇲 🇹' was received but username is 'Wild Kindhearted Wildebeast' instead of user_525144258. Message 'message with new line' was received but username is 'Wild Kindhearted Wildebeast' instead of user_525144258. Message '/command' was received but username is 'Pointed Sociable Crustacean' instead of user_525144218. Message 'ţēšț мεŝšȁǥě 犈好' was received but username is 'Pointed Sociable Crustacean' instead of user_525144218. Message 'This is text message.' was received but username is 'Pointed Sociable Crustacean' instead of user_525144218 Device sessions: Device 1 Device 2

6. test_delete_1_1_chat

Looking for full text: 'Sent' Looking for CommandsButton E selenium.common.exceptions.NoSuchElementException: Message: 'CommandsButton' is not found on screen, using: 'accessibility id:chat-commands-button' Device sessions: Device 1 Device 2

7. test_transaction_send_command_one_to_one_chat

Wait for EnterPasswordInput Looking for EnterPasswordInput E selenium.common.exceptions.NoSuchElementException: Message: 'EnterPasswordInput' is not found on screen, using: 'accessibility id:enter-password-input' Device sessions: Device 1

Passed tests (21)

Click to expand

1. test_sign_transaction_twice

Device sessions: Device 1

2. test_swipe_and_delete_1_1_chat

Device sessions: Device 1

3. test_one_to_one_chat_messages

Device sessions: Device 1 Device 2

4. test_copy_and_paste_messages

Device sessions: Device 1

5. test_send_eth_from_wallet_sign_now

Device sessions: Device 1

6. test_open_transaction_on_etherscan

Device sessions: Device 1

7. test_send_eth_to_request_from_wallet

Device sessions: Device 1 Device 2

8. test_incorrect_password

Device sessions: Device 1

9. test_backup_seed_phrase_and_recover_account

Device sessions: Device 1

10. test_offline_messaging_1_1_chat

Device sessions: Device 1 Device 2

11. test_public_chat_management

Device sessions: Device 1 Device 2

12. test_network_switch

Device sessions: Device 1

13. test_wallet_error_messages

Device sessions: Device 1

14. test_browse_link_entering_url_in_dapp_view

Device sessions: Device 1

15. test_transaction_send_command_wrong_password

Device sessions: Device 1

16. test_send_eth_to_request_in_one_to_one_chat

Device sessions: Device 1 Device 2

17. test_profile_picture

Device sessions: Device 1

18. test_switch_users

Device sessions: Device 1

19. test_set_up_wallet

Device sessions: Device 1

20. test_send_stt_from_wallet_via_enter_recipient_address

Device sessions: Device 1

21. test_qr_code_and_its_value

Device sessions: Device 1

[jakubgs]

Merged manually via scripts/merge-pr.sh at e38ed41