feat: Dont use ntp servers when Thirdparty services are disabled#7197
Merged
Khushboo-dev-cpp merged 1 commit intodevelopfrom Dec 17, 2025
Merged
feat: Dont use ntp servers when Thirdparty services are disabled#7197Khushboo-dev-cpp merged 1 commit intodevelopfrom
Khushboo-dev-cpp merged 1 commit intodevelopfrom
Conversation
Member
Jenkins BuildsClick to see older builds (60)
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7197 +/- ##
===========================================
+ Coverage 51.26% 59.74% +8.48%
===========================================
Files 820 819 -1
Lines 113826 113297 -529
===========================================
+ Hits 58349 67690 +9341
+ Misses 49380 38734 -10646
- Partials 6097 6873 +776
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1 task
Khushboo-dev-cpp
force-pushed
the
feat/thirdPartyServicesNtpServers
branch
from
c7a317b to
4ce8f1f
Compare
Khushboo-dev-cpp
force-pushed
the
feat/thirdPartyServicesNtpServers
branch
from
4ce8f1f to
2218318
Compare
Khushboo-dev-cpp
force-pushed
the
feat/thirdPartyServicesNtpServers
branch
3 times, most recently
from
8ccd0bd to
b87fcf2
Compare
Member
✔️ status-go/prs/tests/PR-7197#5 🔹 ~25 min 🔹 8ccd0bd 🔹 📦 tests package |
Khushboo-dev-cpp
force-pushed
the
feat/thirdPartyServicesNtpServers
branch
from
b87fcf2 to
fdce026
Compare
Comment on lines
432
to
433
| b.logger.Error("failed to get if thirdparty services enabled", zap.Error(err)) | ||
| return timesource.LocalService() |
Collaborator
There was a problem hiding this comment.
Returning here won't actually set the b.timeSourceSrvc, which we should do
We can just set thirdpartyServicesEnabled to false and let the next code do the job
Suggested change
| b.logger.Error("failed to get if thirdparty services enabled", zap.Error(err)) | |
| return timesource.LocalService() | |
| b.logger.Error("failed to get if thirdparty services enabled", zap.Error(err)) | |
| thirdpartyServicesEnabled = true |
Collaborator
|
@Khushboo-dev-cpp CI will be fixed tomorrow, sorry for that |
Khushboo-dev-cpp
force-pushed
the
feat/thirdPartyServicesNtpServers
branch
from
fdce026 to
20da234
Compare
Khushboo-dev-cpp
force-pushed
the
feat/thirdPartyServicesNtpServers
branch
from
20da234 to
61a4935
Compare
igor-sirotin
approved these changes
Dec 17, 2025
alexjba
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A short summary which serves as a squashed-commit message.
A description to understand introduced changes without reading the code.
Important changes:
Closes #