-
Notifications
You must be signed in to change notification settings - Fork 262
feat!: a new token list approach - wallet sdk token lists integration #6912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
saledjenic
wants to merge
2
commits into
develop
Choose a base branch
from
feat/new-token-list-approach
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (295)
|
5fdbea8
to
119e1b7
Compare
13ad01f
to
c54bd12
Compare
41cffc7
to
96dc9bd
Compare
38cef51
to
4e22c96
Compare
934352f
to
c107513
Compare
68bbd3c
to
9ce6817
Compare
9ce6817
to
6e0549f
Compare
6e0549f
to
eb710dc
Compare
10ce4f8
to
ef5d38e
Compare
7d4481e
to
a745db8
Compare
fbarbu15
approved these changes
Sep 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test part LGTM, thanks
d40d32a
to
dabb450
Compare
alaibe
approved these changes
Oct 2, 2025
f6ddcd9
to
7e57262
Compare
afc5de1
to
362c74c
Compare
e497266
to
7bc3e08
Compare
7bc3e08
to
453482a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
General changes:
API changes:
GetBalancesByChain
instead of chain ids and token addresses requirestokenKeys []string
GetTokenList
that was returningListWrapper
is replaced byGetAllTokenLists
and returns[]*tokenlists.TokenList
GetTokens
replaced byGetAllTokens
GetCustomTokens
removedFetchPrices
instead ofsymbols
requires nowtokensKeys []string
FetchMarketValues
instead ofsymbols
requires nowtokensKeys []string
GetHourlyMarketValues
instead ofsymbol
requires nowtokenKey string
GetDailyMarketValues
instead ofsymbol
requires nowtokenKey string
FetchTokenDetails
instead ofsymbols
requires nowtokensKeys []string
New, convenient functions added to the token manager:
GetTokenByChainAddress
GetTokensByChain(chainID uint64) []*tokenlists.Token
GetTokensByChains(chainIDs []uint64) ([]*tokenlists.Token, error)
GetAllTokens() []*tokenlists.Token
GetTokenList(id string) (*tokenlists.TokenList, bool)
GetAllTokenLists() []*tokenlists.TokenList
GetLastTokenListsRefreshTime() (int64, error)
Exposed types that have been updated:
RouteInputParams
TokenID
replaced byTokenKey
TokenIDIsOwnerToken
replaced byTokenIsOwnerToken
ToTokenID
replaced byToTokenKey
SendDetails
FromToken
replaced byFromTokenKey
ToToken
replaced byToTokenKey
RouterSentTransaction
FromToken
replaced byFromTokenKey
ToToken
replaced byToTokenKey
ChainBalance
- removedStorageToken
BalancesPerChain
- replaced by:TokenAddress
TokenChainID
RawBalance
Balance
HasError
List
- removed, array ofTokenList
used insteadListWrapper
- removedSendTxArgsVersion
Symbol
- removedFromTokenID
replaced byFromToken
ToTokenID
replaced byToToken