fix_: community sync #5880
Open
fix_: community sync #5880
+75
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
Could you explain how we can reproduce it in 100%? @osmaczko |
There is no easy way to reproduce. I am trying to come up with integration test for the regression. |
igor-sirotin
approved these changes
Oct 3, 2024
Comment on lines
-3501
to
-3543
| communityDescriptionBytes, err := proto.Marshal(request.Community) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| // We need to wrap `request.Community` in an `ApplicationMetadataMessage` | ||
| // of type `CommunityDescription` because `UpdateCommunityDescription` expects this. | ||
| // | ||
| // This is merely for marsheling/unmarsheling, hence we attaching a `Signature` | ||
| // is not needed. | ||
| metadataMessage := &protobuf.ApplicationMetadataMessage{ | ||
| Payload: communityDescriptionBytes, | ||
| Type: protobuf.ApplicationMetadataMessage_COMMUNITY_DESCRIPTION, | ||
| } | ||
|
|
||
| appMetadataMsg, err := proto.Marshal(metadataMessage) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| isControlNodeSigner := common.IsPubKeyEqual(community.ControlNode(), signer) | ||
| if !isControlNodeSigner { | ||
| m.logger.Debug("signer is not control node", zap.String("signer", common.PubkeyToHex(signer)), zap.String("controlNode", common.PubkeyToHex(community.ControlNode()))) | ||
| return nil, ErrNotAuthorized | ||
| } | ||
|
|
||
| _, processedDescription, err := m.preprocessDescription(community.ID(), request.Community) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| _, err = community.UpdateCommunityDescription(processedDescription, appMetadataMsg, nil) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| if err = m.handleCommunityTokensMetadata(community); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
There was a problem hiding this comment.
Hmm, don't we want to keep this around for 3 versions, until users upgrade?
(only process it if CommunityDescriptionMessage is missing)
osmaczko
force-pushed
the
fix/community-sync
branch
from
5bfb6df
to
6d88d06
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #5880 +/- ##
===========================================
+ Coverage 45.78% 47.40% +1.61%
===========================================
Files 830 830
Lines 137660 137643 -17
===========================================
+ Hits 63034 65251 +2217
+ Misses 67300 64633 -2667
- Partials 7326 7759 +433
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent community description message being stored without signature. Details: status-im/status-mobile#21303 (comment)
fixes: status-im/status-mobile#21303