Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use pkg for output, use out #1574

Merged
merged 1 commit into from
Aug 20, 2019
Merged

don't use pkg for output, use out #1574

merged 1 commit into from
Aug 20, 2019

Conversation

jakubgs
Copy link
Member

@jakubgs jakubgs commented Aug 19, 2019

To fix permission errors at end of builds when cleaning.

@jakubgs jakubgs requested a review from adambabik August 19, 2019 18:59
@jakubgs jakubgs self-assigned this Aug 19, 2019
@status-github-bot
Copy link

status-github-bot bot commented Aug 19, 2019

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@status-im-auto
Copy link
Member

status-im-auto commented Aug 19, 2019

Jenkins Builds

Click to see older builds (12)
Commit #️⃣ Finished (UTC) Duration Platform Result
0493f24 #1 2019-08-19 18:59:44 ~24 sec android 📄 log
0493f24 #1 2019-08-19 18:59:44 ~23 sec ios 📄 log
✔️ 0493f24 #1 2019-08-19 19:00:45 ~1 min linux 📦 zip
5b595d8 #2 2019-08-19 21:47:39 ~17 sec ios 📄 log
5b595d8 #2 2019-08-19 21:47:44 ~23 sec android 📄 log
✔️ 5b595d8 #2 2019-08-19 21:48:07 ~45 sec linux 📦 zip
43ca0f6 #3 2019-08-19 21:57:13 ~14 sec ios 📄 log
✔️ 43ca0f6 #3 2019-08-19 21:57:34 ~34 sec linux 📦 zip
✔️ 43ca0f6 #3 2019-08-19 22:05:10 ~8 min android 📦 aar
f1b233b #4 2019-08-19 22:05:34 ~15 sec ios 📄 log
✔️ f1b233b #4 2019-08-19 22:06:24 ~1 min linux 📦 zip
✔️ f1b233b #4 2019-08-19 22:11:47 ~6 min android 📦 aar
Commit #️⃣ Finished (UTC) Duration Platform Result
b5e4e01 #5 2019-08-19 22:22:00 ~16 sec ios 📄 log
✔️ b5e4e01 #5 2019-08-19 22:22:24 ~39 sec linux 📦 zip
✔️ b5e4e01 #5 2019-08-19 22:28:06 ~6 min android 📦 aar
4fbddc2 #6 2019-08-19 22:31:48 ~20 sec ios 📄 log
✔️ 4fbddc2 #6 2019-08-19 22:32:01 ~32 sec linux 📦 zip
✔️ 4fbddc2 #6 2019-08-19 22:38:09 ~6 min android 📦 aar
✔️ 4fbddc2 #7 2019-08-20 05:30:09 ~3 min ios 📦 zip

@jakubgs
Copy link
Member Author

jakubgs commented Aug 19, 2019

It still fails on this weird error:

Building status-go for iOS...
gomobile init
gomobile bind -v -target=ios -ldflags="-s -w" -ldflags ' -X main.buildStamp=2019-08-19.22:33:56 -X github.com/status-im/status-go/params.Version=0.32.0-beta.0 -X github.com/status-im/status-go/params.GitCommit=4fbddc2e -X github.com/status-im/status-go/vendor/github.com/ethereum/go-ethereum/metrics.EnabledStr=true' -o build/bin/Statusgo.framework github.com/status-im/status-go/mobile
2019/08/19 23:33:59 go [list -e -json -compiled=true -test=false -export=false -deps=true -find=false -tags ios -- github.com/status-im/status-go/mobile]: exit status 1: go build github.com/status-im/status-go/vendor/github.com/ethereum/go-ethereum/crypto/secp256k1: build constraints exclude all Go files in /Users/jenkins/workspace/status-go/platforms/ios/src/github.com/status-im/status-go/vendor/github.com/ethereum/go-ethereum/crypto/secp256k1
gomobile: /Users/jenkins/workspace/status-go/platforms/ios/bin/gobind -lang=go,objc -outdir=/var/folders/pc/sgwfk7115_7b8dndw3xgz_0r0000gp/T/gomobile-work-019434551 -tags=ios github.com/status-im/status-go/mobile failed: exit 

No idea what build constraints exclude all Go files means.

@jakubgs
Copy link
Member Author

jakubgs commented Aug 19, 2019

This seems to be related to CGO, but not sure how.

@adambabik
Copy link
Contributor

@jakubgs I just rerun iOS build and it passed... Magic.

@adambabik adambabik merged commit 652d8a6 into develop Aug 20, 2019
@adambabik adambabik deleted the change-output-dir branch August 20, 2019 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants