chore: improvements of the sending route generated by the router process #16330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saledjenic
requested review from
alaibe,
dlipicar,
Cuteivist,
alexjba,
Khushboo-dev-cpp,
virginiabalducci,
anastasiyaig and
a team
Jenkins BuildsClick to see older builds (38)
|
|
Send: Test user's geth.log geth.log.zip
Swap:
UPD (nastya): i was able to do swap erc20 to erc20 https://etherscan.io//tx//0x19a1eaefbc75ab9ace48987d4807a3addfcba19049a16437a1da7788197c3e1e UPD (nastya): i was able to do bridge as well Bridge: |
|
testing this PR is blocked due to #16352 because I need to send some funds to bridge and get them to L2, to test the Bridge functionality in the desktop app, and to test swap on L2 networks. |
alaibe
approved these changes
Sep 17, 2024
saledjenic
force-pushed
the
transaction-improvements
branch
from
9b4e506
to
a40b807
Compare
@virginiabalducci I added a comment to the issue you logged, also rebased this PR on top of Dario's change for the disabled send button, could you try it out again? |
|
@saledjenic i was able to do the remaining part of transactions (swap and bridge). it looks fine |
anastasiyaig
approved these changes
Sep 17, 2024
virginiabalducci
approved these changes
Sep 17, 2024
saledjenic
force-pushed
the
transaction-improvements
branch
from
a40b807
to
58668a0
Compare
saledjenic
force-pushed
the
transaction-improvements
branch
from
58668a0
to
aad983a
Compare
saledjenic
force-pushed
the
transaction-improvements
branch
from
aad983a
to
947c444
Compare
saledjenic
force-pushed
the
transaction-improvements
branch
from
947c444
to
ce4257f
Compare
✔️ status-desktop/prs/macos/aarch64/package/PR-16330#6 🔹 ~5 min 45 sec 🔹 ce4257f 🔹 📦 macos/aarch64 package |
Based on changes done in this PR status-im/status-go#5807 we can simplify our client logic a lot. This results in the removal of many lines of code that are no longer needed Closes 1st part of #16336
saledjenic
force-pushed
the
transaction-improvements
branch
from
42331ed
to
01f6c45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding
status-goPR:This PR is the first step in the improvement planned for the desktop app. Next steps:
Note: minimal changes are done in the swap modal part on the qml side just to support new sending transaction flow, further improvements are necessary there
Closes #16335
Affected areas by this change are Send, Bridge and Swap modal, would be good to test the following: