chore: some improvements on the storybook side #19561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saledjenic
requested review from
a team,
alexjba and
noeliaSD
as code owners
Member
✔️ status-app/prs/linux/x86_64/tests-nim/PR-19561#1 🔹 ~17 min 🔹 8ce79e6 🔹 📦 tests/nim package |
Member
✔️ status-app/prs/linux/x86_64/tests-ui/PR-19561#1 🔹 ~20 min 🔹 8ce79e6 🔹 📦 tests/ui package |
Member
Member
Member
Jenkins BuildsClick to see older builds (26)
|
caybro
approved these changes
Dec 15, 2025
saledjenic
force-pushed
the
chore/storybook-improvements
branch
from
8ce79e6 to
8c4e9aa
Compare
micieslak
reviewed
Dec 17, 2025
Member
micieslak
left a comment
micieslak
left a comment
There was a problem hiding this comment.
Looks ok, but please do some changes in the files structures:
- instead of adding mocks into stubs, please put it under
storybook/src/Mocksdirectory directly (storybook/src/Mocks/TokensStoreMock.qml, we don't have to follow the dir structure of actual store). Then what you need is to just importimport Mocks, same way as we already haveimport Modelsorimport Storybook. - the mocks don't have to have the same name as actual store. What matters is inheritance. It will be also handier to use it just as e.g.
tokensStore: TokensStoreMock {}without involving aliases. It's more readable imo, and less confusing for QtCreator :) - please do the same for
WalletAssetsStore, keep it asQtObject {}.
…usage with WalletAssetsStoreMock across qml pages and tests
saledjenic
force-pushed
the
chore/storybook-improvements
branch
from
8c4e9aa to
c5d9fba
Compare
Contributor
Author
|
@micieslak updated, please have a look. |
…sage with TransactionStoreMock across qml pages and tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying comments from an already merged PR, #18965 (review)