fix(onboarding): Delay the keycard detection for when keycard is needed #19547
+195
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjba
requested review from
a team,
caybro,
micieslak and
noeliaSD
as code owners
Member
Member
✔️ status-desktop/prs/linux/x86_64/tests-ui/PR-19547#1 🔹 ~15 min 🔹 39ed060 🔹 📦 tests/ui package |
Member
Member
Member
Member
Member
✔️ status-desktop/e2e/prs-windowsPR19547 🔹 ~22 min 🔹 39ed060 🔹 📦 tests/e2e-windows package |
alexjba
force-pushed
the
fix/keycard-nfc-1
branch
from
3eacf69 to
1bb9a1e
Compare
alexjba
requested review from
friofry and
vkjr
and removed request for
a team
alexjba
force-pushed
the
fix/keycard-nfc-2
branch
from
39ed060 to
d281472
Compare
Member
Member
Member
Member
Member
✔️ status-desktop/prs/linux/x86_64/tests-ui/PR-19547#2 🔹 ~24 min 🔹 d281472 🔹 📦 tests/ui package |
Member
Member
Member
Member
✔️ status-desktop/e2e/prspr19547 🔹 ~23 min 🔹 d281472 🔹 📦 tests/e2e package |
alexjba
force-pushed
the
fix/keycard-nfc-1
branch
from
1bb9a1e to
e9d79a4
Compare
alexjba
force-pushed
the
fix/keycard-nfc-2
branch
from
d281472 to
e64335b
Compare
Member
✔️ status-app/prs/linux/x86_64/tests-ui/PR-19547#3 🔹 ~1 hr 6 min 🔹 e64335b 🔹 📦 tests/ui package |
alexjba
force-pushed
the
fix/keycard-nfc-2
branch
from
e64335b to
92e99e9
Compare
Member
✔️ status-app/prs/android/arm64/package/PR-19547#4 🔹 ~11 min 🔹 1e73bf1c 🔹 📦 android/arm64 package |
Member
✔️ status-app/prs/linux/x86_64/tests-nim/PR-19547#4 🔹 ~18 min 🔹 92e99e9 🔹 📦 tests/nim package |
Member
Member
Member
✔️ status-app/prs/linux/x86_64/tests-ui/PR-19547#4 🔹 ~23 min 🔹 92e99e9 🔹 📦 tests/ui package |
Member
alexjba
force-pushed
the
fix/keycard-nfc-1
branch
from
e9d79a4 to
58d65b8
Compare
alexjba
force-pushed
the
fix/keycard-nfc-2
branch
from
92e99e9 to
397f697
Compare
saledjenic
approved these changes
Dec 11, 2025
Member
Member
✔️ status-app/prs/linux/x86_64/tests-nim/PR-19547#5 🔹 ~17 min 🔹 397f697 🔹 📦 tests/nim package |
Member
Member
✔️ status-app/prs/linux/x86_64/tests-ui/PR-19547#5 🔹 ~22 min 🔹 397f697 🔹 📦 tests/ui package |
Member
caybro
approved these changes
Dec 15, 2025
Member
caybro
left a comment
caybro
left a comment
There was a problem hiding this comment.
Cool :) Would be nice to add a small QML test to tst_OnboardingLayout.qml
alexjba
force-pushed
the
fix/keycard-nfc-1
branch
from
58d65b8 to
f2eb2e9
Compare
alexjba
force-pushed
the
fix/keycard-nfc-2
branch
from
397f697 to
41159d3
Compare
Member
Jenkins BuildsClick to see older builds (50)
|
friofry
reviewed
Dec 22, 2025
| error "error storing metadata", err=e.msg | ||
|
|
||
| proc startDetection*(self: Service) {.featureGuard(KEYCARD_ENABLED).} = | ||
| self.asyncStart(status_const.KEYCARDPAIRINGDATAFILE) |
Contributor
There was a problem hiding this comment.
Should we ignore the signal if there is a previous detection in progress?
Contributor
Author
There was a problem hiding this comment.
Not necessarily. Start can be called at any point even if the API was previously started. So the keycard client doesn't need to track the API state. The result will be a re-read of keycard to get the current metadata. It's probably something we'll want either way.
friofry
approved these changes
Dec 22, 2025
Contributor
friofry
left a comment
friofry
left a comment
There was a problem hiding this comment.
Looks good to me!
Added a comment
alexjba
force-pushed
the
fix/keycard-nfc-1
branch
from
f2eb2e9 to
a18039a
Compare
This is a fix for the mobile platforms that will show a drawer when the keycard is needed. We'll need to avoid showing the drawer every time at app start.
alexjba
force-pushed
the
fix/keycard-nfc-2
branch
from
41159d3 to
d606f25
Compare
vkjr
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Iterates #19545 #19546
This is a fix for the mobile platforms that will show a drawer when the keycard is needed. We'll need to avoid showing the drawer every time at app start.
The UI will signal the onboarding module whenever the keycard is needed to start the session API.
NOTE: Tests can be done in the final PR #19549