ios: create and sign separate bundle ID for PRs #19505
Merged
+828
−463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Jenkins BuildsClick to see older builds (15)
|
siddarthkay
force-pushed
the
fix-ios-signing
branch
from
091d40a to
a011dd8
Compare
Member
✔️ status-desktop/prs/android/arm64/package/PR-19505#5 🔹 ~12 min 🔹 bae4abc9 🔹 📦 android/arm64 package |
siddarthkay
force-pushed
the
fix-ios-signing
branch
3 times, most recently
from
47ae31a to
f0d0ce0
Compare
Member
Jenkins BuildsClick to see older builds (641)
|
siddarthkay
force-pushed
the
fix-ios-signing
branch
13 times, most recently
from
42a65d4 to
41514ea
Compare
siddarthkay
force-pushed
the
fix-ios-signing
branch
3 times, most recently
from
9e816b7 to
6b92160
Compare
yakimant
reviewed
Dec 17, 2025
Member
yakimant
left a comment
yakimant
left a comment
There was a problem hiding this comment.
Left some comments, please have a look. (also in jenkin lib repo)
Will be happy to do a second go.
siddarthkay
force-pushed
the
fix-ios-signing
branch
8 times, most recently
from
a237eed to
d4aa895
Compare
siddarthkay
changed the title
yakimant
approved these changes
Dec 22, 2025
Member
yakimant
left a comment
yakimant
left a comment
There was a problem hiding this comment.
Few comments, but good in general!
alexjba
approved these changes
Dec 22, 2025
Contributor
alexjba
left a comment
alexjba
left a comment
There was a problem hiding this comment.
LGTM! Although the upload to diawi seems to fail.
siddarthkay
force-pushed
the
fix-ios-signing
branch
from
d4aa895 to
2806321
Compare
Contributor
Author
Thanks for catching that, I fixed in latest push. |
siddarthkay
force-pushed
the
fix-ios-signing
branch
7 times, most recently
from
754b675 to
2f0c125
Compare
siddarthkay
requested review from
alaibe and
vkjr
and removed request for
a team
- points to `fix-ios-signing-with-fastlane` branch of `status-jenkins-lib` which provides development certs for PR builds and distribution certs for release builds. - adds nix flake to provide ruby dependencies for `fastlane` - adds config for new build identifier for PRs: `app.status.mobile.pr` - swaps testflight script with fastlane action - adds job to build iOS in release - updates status-go to use nim-sds from logos-messaging/nim-sds#41
siddarthkay
force-pushed
the
fix-ios-signing
branch
from
036da79 to
1a9708f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix-ios-signing-with-fastlanebranch ofstatus-jenkins-libwhich provides development certs for PR builds and distribution certs for release builds.fastlaneapp.status.mobile.prDepends on :