This repository has been archived by the owner on Apr 26, 2019. It is now read-only.
Add warning icon when user profile is incomplete #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. All links on SOB redirect to landing pageSteps:
Actual result:no redirect to
Expected result:
Video: http://take.ms/sTY0j
|
|
Tracking it down. |
|
@siphiuel not entirely sure but could be CircleCI is failing because this isn't rebased against master? |
| repo-count (rf/subscribe [:get-in [:user :repo_count]]) | ||
| hide-address-warning (rf/subscribe [:get-in [:user :hide_address_warning]]) | ||
| hide-gh-repos-warning (rf/subscribe [:get-in [:user :hide_gh_repos_warning]]) | ||
| warning-open? (rf/subscribe [:warning-open?])] |
There was a problem hiding this comment.
These :get-in subscriptions can lead to problems should we ever change the structure of our app-db. Not a big deal for now but worth keeping in mind. Suggestions: Have a :user subscription that returns full user map.
src/cljs/commiteth/core.cljs
Outdated
| [:div [:input {:type "checkbox" | ||
| :id :hide-warning | ||
| :on-change on-change-fn}] | ||
| [:label {:for :hide-warning} "Do not show this again"]]])]))))) |
There was a problem hiding this comment.
Nice one on using for 👍
|
@martinklepsch Regarding CircleCI - yes, the branch still does not contain generated Java contracts. |
|
@siphiuel |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #352
Following changes are made:
is_hidden_in_huntersflag in aoptsJSONB field.Status: Done