Skip to content
This repository has been archived by the owner on Apr 26, 2019. It is now read-only.

Metamask address is not updated automatically in Payment Details #187

Closed
churik opened this issue Dec 8, 2017 · 4 comments
Closed

Metamask address is not updated automatically in Payment Details #187

churik opened this issue Dec 8, 2017 · 4 comments

Comments

@churik
Copy link
Member

churik commented Dec 8, 2017

Description

Type: Bug

Summary:
when you setup Metamask, unlock it with your browser, login to SOB and go "My payment details" you see new address from MetaMask, but it is not really updated UNTIL you click update manually.
For you it looks like new address, but in database old address remains.

Expected behavior

address is updated in database (new address from MetaMask is set)

Actual behavior

address is updated on SOB but remains old (or empty, if it is first time) in DB
Only after you click UPDATE on SOB > Payment Details, it will be updated in DB

Reproduction

  • Open SOB
  • Log in with user who set address manually or with new user
  • Connect MetaMask for first time
  • Go to "Payment Details"
@churik churik added the bug label Dec 8, 2017
@churik churik changed the title Metamask address is not set automatically Metamask address is not updated automatically on Payment Details Dec 8, 2017
@churik churik changed the title Metamask address is not updated automatically on Payment Details Metamask address is not updated automatically in Payment Details Dec 8, 2017
@vitvly vitvly self-assigned this Jan 29, 2018
@vitvly vitvly closed this as completed in 3c4413b Feb 6, 2018
vitvly pushed a commit that referenced this issue Feb 6, 2018
…ed-#187

[FIX #187] Fix address dropdown in My Payment Details
vitvly pushed a commit that referenced this issue Feb 6, 2018
…s-not-updated-#187

Revert "[FIX #187] Fix address dropdown in My Payment Details"
@vitvly vitvly reopened this Feb 6, 2018
@vitvly vitvly closed this as completed in 27d189f Feb 8, 2018
vitvly pushed a commit that referenced this issue Feb 8, 2018
…mask-address-not-updated-#187

Revert "Revert "[FIX #187] Fix address dropdown in My Payment Details""
@churik
Copy link
Member Author

churik commented Feb 8, 2018

1. Address is reset in "Payment details" after page reload

Steps:

Scenario 1:

Scenario 2:

Actual result:

"Select address" is displayed

Expected result:

new address (same as in database)

Video: http://take.ms/9rMqd
OS: Mac OSx
Browser: Chrome

@vitvly
Copy link

vitvly commented Feb 8, 2018

Created a PR with a fix for this: #263

vitvly pushed a commit that referenced this issue Feb 9, 2018
vitvly pushed a commit that referenced this issue Feb 9, 2018
…40-fix/metamask-address-not-updated-#187

Revert "[FIX #187] Fix address dropdown in My Payment Details"
@pablodip pablodip reopened this Feb 14, 2018
@pablodip
Copy link
Contributor

@siphiuel Where is the current pull request of this issue? :S

@vitvly
Copy link

vitvly commented Feb 15, 2018

This would be #263.

@vitvly vitvly closed this as completed in 714b869 Feb 15, 2018
vitvly referenced this issue Feb 16, 2018
vitvly pushed a commit that referenced this issue Feb 16, 2018
…51-revert-240-fix/metamask-address-not-updated-#187

Revert "Revert "[FIX #187] Fix address dropdown in My Payment Details""
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants