Add parent_block_root to bid filtering key - #8510
Merged
Merged
Conversation
The gossip rule was changed from: > [IGNORE] This bid is the highest value bid seen for the corresponding > slot and the given parent block hash to: > [IGNORE] this bid is the highest value bid seen for the tuple > (bid.slot, bid.parent_block_hash, bid.parent_block_root)`. - ethereum/consensus-specs#5001 This way, someone can't just abuse a reorg to bid a large amount on a non-canonical branch to purge the canonical bid. Catch up with spec. Further, clean up the `parentExecHash != bid.parent_block_hash` check which is not from spec and rejected bids building on the timeline where the parent block's payload was withheld, by tracking the bids in the pool separately based on timeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gossip rule was changed from:
to:
parent_block_rootto bid filtering key ethereum/consensus-specs#5001This way, someone can't just abuse a reorg to bid a large amount on a non-canonical branch to purge the canonical bid. Catch up with spec.
Further, clean up the
parentExecHash != bid.parent_block_hashcheck which is not from spec and rejected bids building on the timeline where the parent block's payload was withheld, by tracking the bids in the pool separately based on timeline.