Only update proposer boost if proposer is same as on canonical chain - #8104
Merged
Conversation
From ethereum/consensus-specs#4807: > There's a few changes. Firstly, there's a fix to the mechanism for > setting the proposer boost root: we only update it if > `block.proposer_index` matches the expected proposer of your current > `head_state`. This way you can't nullify proposer boost by just > creating forks with a divergent proposer sequence. Also small refactor > with the updating logic moved to `update_proposer_boost_root`, and the > block timeliness logic in `record_block_timeliness`. All of this is > essentially unrelated to epbs. Having to pull a fresh EpochRef is unfortunate, the existing one given to `process_block` is not necessarily compatible with the canonical one. Should be cached, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From ethereum/consensus-specs#4807:
Having to pull a fresh EpochRef is unfortunate, the existing one given to
process_blockis not necessarily compatible with the canonical one. Should be cached, though.