Conversation
agnxsh
changed the title
engine_getBlobsV3 helpers for cell level dissemination
Contributor
tersec
reviewed
Jan 12, 2026
| sidecars | ||
|
|
||
| proc assemble_partial_data_column_sidecars*( | ||
| signed_beacon_block: fulu.SignedBeaconBlock | gloas.SignedBeaconBlock, |
Contributor
There was a problem hiding this comment.
This doesn't appear to actually work/do anything for Gloas?
Contributor
Author
There was a problem hiding this comment.
it doesn't, it was added anticipating, this feature would roll over in gloas
tersec
reviewed
Jan 12, 2026
beacon_chain/el/el_manager.nim
Outdated
|
|
||
| proc sendGetBlobsV3*( | ||
| m: ElManager, | ||
| blck: fulu.SignedBeaconBlock | gloas.SignedBeaconBlock |
Contributor
There was a problem hiding this comment.
This doesn't actually handle gloas in any useful way?
Contributor
Author
There was a problem hiding this comment.
it doesn't, it was added anticipating, this feature would roll over in gloas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ethereum/execution-apis#674
ethereum/consensus-specs#4558