Skip to content

add KZG commitment to first-blob-found check in blobs gossip validation #6912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tersec merged 1 commit into from
Feb 10, 2025
Merged

add KZG commitment to first-blob-found check in blobs gossip validation #6912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions beacon_chain/consensus_object_pools/blob_quarantine.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,14 @@ func hasBlob*(
quarantine: BlobQuarantine,
slot: Slot,
proposer_index: uint64,
index: BlobIndex): bool =
index: BlobIndex,
kzg_commitment: KzgCommitment): bool =
for blob_sidecar in quarantine.blobs.values:
template block_header: untyped = blob_sidecar.signed_block_header.message
if block_header.slot == slot and
block_header.proposer_index == proposer_index and
blob_sidecar.index == index:
blob_sidecar.index == index and
blob_sidecar.kzg_commitment == kzg_commitment:
return true
false

Expand Down
14 changes: 13 additions & 1 deletion beacon_chain/gossip_processing/gossip_validation.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,8 +423,20 @@ proc validateBlobSidecar*(
let block_root = hash_tree_root(block_header)
if dag.getBlockRef(block_root).isSome():
return errIgnore("BlobSidecar: already have block")

# This adds KZG commitment matching to the spec gossip validation. It's an
# IGNORE condition, so it shouldn't affect Nimbus's scoring, and when some
# (slashable) double proposals happen with blobs present, without this one
# or the other block, or potentially both, won't get its full set of blobs
# through gossip validation and have to backfill them later. There is some
# cost in slightly more outgoing bandwidth on such double-proposals but it
# remains insignificant compared with other bandwidth usage.
#
# It would be good to fix this more properly, but this has come up often on
# Pectra devnet-6.
if blobQuarantine[].hasBlob(
block_header.slot, block_header.proposer_index, blob_sidecar.index):
block_header.slot, block_header.proposer_index, blob_sidecar.index,
blob_sidecar.kzg_commitment):
return errIgnore("BlobSidecar: already have valid blob from same proposer")

# [REJECT] The sidecar's inclusion proof is valid as verified by
Expand Down