Skip to content

Obtain extra LightClientFinalityUpdate after LC sync #6752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tersec merged 1 commit into from
Dec 5, 2024
Merged

Obtain extra LightClientFinalityUpdate after LC sync #6752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 28 additions & 9 deletions beacon_chain/sync/light_client_manager.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,10 @@ template query[E](

# https://github.com/ethereum/consensus-specs/blob/v1.5.0-alpha.9/specs/altair/light-client/light-client.md#light-client-sync-process
proc loop(self: LightClientManager) {.async: (raises: [CancelledError]).} =
var nextSyncTaskTime = self.getBeaconTime()
var
nextSyncTaskTime = self.getBeaconTime()
wasGossipSupported = false
haveFinalityUpdate = false
while true:
# Periodically wake and check for changes
let wallTime = self.getBeaconTime()
Expand Down Expand Up @@ -373,16 +376,32 @@ proc loop(self: LightClientManager) {.async: (raises: [CancelledError]).} =
await self.query(UpdatesByRange,
(startPeriod: syncTask.startPeriod, count: syncTask.count))
of LcSyncKind.FinalityUpdate:
haveFinalityUpdate = true
await self.query(FinalityUpdate)
of LcSyncKind.OptimisticUpdate:
await self.query(OptimisticUpdate)

nextSyncTaskTime = wallTime + self.rng.nextLcSyncTaskDelay(
wallTime,
finalized = self.getFinalizedPeriod(),
optimistic = self.getOptimisticPeriod(),
isNextSyncCommitteeKnown = self.isNextSyncCommitteeKnown(),
didLatestSyncTaskProgress = didProgress)
if not haveFinalityUpdate:
haveFinalityUpdate = true
await self.query(FinalityUpdate)
else:
await self.query(OptimisticUpdate)

let
finalized = self.getFinalizedPeriod()
optimistic = self.getOptimisticPeriod()
isNextSyncCommitteeKnown = self.isNextSyncCommitteeKnown()
isGossipSupported =
current.isGossipSupported(finalized, isNextSyncCommitteeKnown)
nextSyncTaskTime =
if not wasGossipSupported and isGossipSupported:
# Obtain an extra finality update after finishing sync
# to avoid having to wait several minutes for finality gossip
haveFinalityUpdate = false
wallTime
else:
wallTime + self.rng.nextLcSyncTaskDelay(
wallTime, finalized, optimistic, isNextSyncCommitteeKnown,
didLatestSyncTaskProgress = didProgress)
wasGossipSupported = isGossipSupported

proc start*(self: var LightClientManager) =
## Start light client manager's loop.
Expand Down