Use Pippenger multiplication for combining multiple sigs of same msg #6484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer `blst` releases expose multiscalar Pippenger multiplication that allows accelerated verification of signatures pertaining to same msg. - https://gist.github.com/wemeetagain/d52fc4b077f80db6e423935244c2afb2
tersec
reviewed
Aug 16, 2024
| blsVerify(batch[].sigsets[0]) | ||
| var r = true | ||
| for multiSet in batch[].multiSets.values(): | ||
| r = r and blsVerify(multiSet.combine(verifier)) |
There was a problem hiding this comment.
why not early-exit on not blsVerify()? keep constant time, or is there some other motivation
There was a problem hiding this comment.
there's only a single entry in there anyway. but can add a break as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer
blstreleases expose multiscalar Pippenger multiplication that allows accelerated verification of signatures pertaining to same msg.