remove extraneous length checks in KZG batch proofs #5744
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are replicated in https://github.com/ethereum/c-kzg-4844/blob/d637761a2ece4f13dbcffcae09253408e430a6e1/bindings/nim/kzg.nim#L181-L202
Which is recognized by ethereum/consensus-specs@468b5be and ethereum/consensus-specs#3368
As such, the spec removed the wrapper function. It's useful to keep the wrapper here, because it coalesces the two failure modes of failure-in-trying-to-verify with successful verification, procedurally, which rejected the proof/commitment/blob tuple. Downstream code largely doesn't care, except insofar as it would like to be able to generate more informative error messages, so keeping this wrapper avoids code duplication elsewhere.
Still, it's not in spec as of v1.4.0, so remove consensus spec reference URL.