Conversation
zah
reviewed
May 11, 2023
| ./test_blockchain_dag, | ||
| ./test_keystore, | ||
| ./test_keystore_management, | ||
| ./test_keymanager_api |
Contributor
There was a problem hiding this comment.
The flaky tests are test_keymanager_api and test_signing_node. test_keystore_management is mostly doing file I/O and test_keystore is mostly about the serialization and cryptography and these have been running smoothly.
Contributor
There was a problem hiding this comment.
@zah, let's please prioritize fixing the tests then. Flaky CI is super time consuming for everyone (not just the maintainers of these flaky tests); the tests should be disabled in CI until they are capable of running reliably. When they run reliably again, just add them back to run on CI.
etan-status
approved these changes
May 12, 2023
This was referenced May 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
9 times in the last day alone: #4619 (comment)