Skip to content

use next slot when signing for light client tests #3447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etan-status merged 1 commit into from
Mar 2, 2022
Merged

use next slot when signing for light client tests #3447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions tests/consensus_spec/altair/test_fixture_sync_protocol.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import
# https://github.com/ethereum/consensus-specs/blob/v1.1.9/tests/core/pyspec/eth2spec/test/helpers/sync_committee.py#L27-L44
proc compute_aggregate_sync_committee_signature(
forked: ForkedHashedBeaconState,
signature_slot: Slot,
participants: openArray[ValidatorIndex],
block_root: Eth2Digest): ValidatorSig =
template state: untyped {.inject.} = forked.altairData.data
Expand All @@ -41,7 +42,7 @@ proc compute_aggregate_sync_committee_signature(
signature = get_sync_committee_message_signature(
state.fork,
state.genesis_validators_root,
state.slot,
signature_slot,
block_root,
privkey)
if not initialized:
Expand Down Expand Up @@ -107,12 +108,13 @@ suite "EF - Altair - Unittests - Sync protocol" & preset():
block_header = signed_block.toBeaconBlockHeader

# Sync committee signing the block_header
signature_slot = block_header.slot + 1
all_pubkeys = state.validators.mapIt(it.pubkey)
committee = state.current_sync_committee.pubkeys
.mapIt(all_pubkeys.find(it).ValidatorIndex)
sync_committee_bits = full_sync_committee_bits
sync_committee_signature = compute_aggregate_sync_committee_signature(
forked[], committee, block_header.hash_tree_root())
forked[], signature_slot, committee, block_header.hash_tree_root())
sync_aggregate = SyncAggregate(
sync_committee_bits: sync_committee_bits,
sync_committee_signature: sync_committee_signature)
Expand Down Expand Up @@ -140,7 +142,7 @@ suite "EF - Altair - Unittests - Sync protocol" & preset():
sync_aggregate: sync_aggregate,
fork_version: state.fork.current_version)
res = process_light_client_update(
store, update, state.slot, state.genesis_validators_root)
store, update, signature_slot, state.genesis_validators_root)

check:
res
Expand Down Expand Up @@ -171,12 +173,13 @@ suite "EF - Altair - Unittests - Sync protocol" & preset():
block_header = signed_block.toBeaconBlockHeader

# Sync committee signing the block_header
signature_slot = block_header.slot + 1
all_pubkeys = state.validators.mapIt(it.pubkey)
committee = state.current_sync_committee.pubkeys
.mapIt(all_pubkeys.find(it).ValidatorIndex)
sync_committee_bits = full_sync_committee_bits
sync_committee_signature = compute_aggregate_sync_committee_signature(
forked[], committee, block_header.hash_tree_root())
forked[], signature_slot, committee, block_header.hash_tree_root())
sync_aggregate = SyncAggregate(
sync_committee_bits: sync_committee_bits,
sync_committee_signature: sync_committee_signature)
Expand All @@ -203,7 +206,7 @@ suite "EF - Altair - Unittests - Sync protocol" & preset():
sync_aggregate: sync_aggregate,
fork_version: state.fork.current_version)
res = process_light_client_update(
store, update, state.slot, state.genesis_validators_root)
store, update, signature_slot, state.genesis_validators_root)

check:
res
Expand Down Expand Up @@ -274,12 +277,13 @@ suite "EF - Altair - Unittests - Sync protocol" & preset():
body_root: blck.body.hash_tree_root())

# Sync committee signing the finalized_block_header
signature_slot = block_header.slot + 1
all_pubkeys = state.validators.mapIt(it.pubkey)
committee = state.current_sync_committee.pubkeys
.mapIt(all_pubkeys.find(it).ValidatorIndex)
sync_committee_bits = full_sync_committee_bits
sync_committee_signature = compute_aggregate_sync_committee_signature(
forked[], committee, block_header.hash_tree_root())
forked[], signature_slot, committee, block_header.hash_tree_root())
sync_aggregate = SyncAggregate(
sync_committee_bits: sync_committee_bits,
sync_committee_signature: sync_committee_signature)
Expand All @@ -293,7 +297,7 @@ suite "EF - Altair - Unittests - Sync protocol" & preset():
sync_aggregate: sync_aggregate,
fork_version: state.fork.current_version)
res = process_light_client_update(
store, update, state.slot, state.genesis_validators_root)
store, update, signature_slot, state.genesis_validators_root)

check:
res
Expand Down