Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hash_ssz: simplify per latest spec update #16

Merged
merged 2 commits into from
Nov 20, 2018
Merged

hash_ssz: simplify per latest spec update #16

merged 2 commits into from
Nov 20, 2018

Conversation

arnetheduck
Copy link
Member

@arnetheduck
hash_ssz: simplify per latest spec update
6df3ec9 
* update per ethereum/consensus-specs#140
* join with ssz to form a single ssz module (like spec)
tersec
tersec reviewed Nov 20, 2018
View reviewed changes
Copy link
Contributor

@tersec tersec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice it's fewer casts.

mratsim
mratsim approved these changes Nov 20, 2018
View reviewed changes
Copy link
Contributor

@mratsim mratsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see comments regarding alignment and ensuring static: assert T.sizeof < 8 in fromBytesSSZUnsafe

beacon_chain/ssz.nim Outdated Show resolved Hide resolved
beacon_chain/ssz.nim Outdated Show resolved Hide resolved
beacon_chain/ssz.nim Show resolved Hide resolved
tersec
tersec approved these changes Nov 20, 2018
View reviewed changes
Copy link
Contributor

@tersec tersec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tersec tersec merged commit 1c9b048 into master Nov 20, 2018
@arnetheduck arnetheduck deleted the simplified_ssz_140 branch November 27, 2018 23:13
etan-status pushed a commit that referenced this pull request May 12, 2022
@cheatfate
Fix #16.
4290e06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tersec tersec tersec approved these changes

@mratsim mratsim mratsim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arnetheduck @tersec @mratsim