Attempt to fix P256verify precompile bug #3759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the latest EEST release is passing, we can merge this |
|
EEST looks good now 45a3d0b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the modification only touch few lines in two functions, but because of how bearssl written, I have to pull the entire
ec_p256_m64.c.Please share your thoughts, should we still use bearssl for the time being or use other library.
With this patch, now
P256verifycan handle h = 0 , h = N, and r = 0 while keeping the patched function operation constant time.EDIT: also can handle when pubkey x or y >= P; fix #3748; fix #3752