Use faststreams comptime support #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitely
commented
Sep 17, 2025
arnetheduck
reviewed
Sep 25, 2025
toml_serialization/types.nim
Outdated
|
|
||
| proc readable*(s: VMInputStream): bool = | ||
| s.pos < s.data.len | ||
| proc peekChar*(s: InputStream): char {.deprecated: "use s.peek().char".} = |
Member
There was a problem hiding this comment.
toml is text based so it stands to reason to have a dedicated char peeker - that said, I don't know that utf8 is being validated correctly when using it so one could also argue we should not have this .. hm .. cc @jangko
Contributor
Author
There was a problem hiding this comment.
the original required peekChar(VMInputStream(s)), but VMInputStream got removed, so I think it's fine to remove peekChar too. If anything peekChar(InputStream) should be defined in faststreams textio module I think. There is also peekChar(TomlLexer) already.
arnetheduck
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nim-faststreams has compile time support now status-im/nim-faststreams#82 .