New {.experimental: "ForLoopMacros".} support #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Due to generics early symbol resolution issue, see nim-lang/Nim#8677, Either all modules (including Nimbus) that uses a comparison or bitwise operator add Or compilation must be done with the CLI flag TODO: add that to stint nim.cfg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an ugly fix to nim-lang/Nim#8676
2152937 was not enough to support the new {.experimental: "ForLoopMacros".} syntax introduced in nim-lang/Nim@da41fc1.
Unfortunately the new syntax is broken as {.experimental: "ForLoopMacros".} is needed everywhere a proc that calls the forLoop macros is used, including in test files, so it leaks implementation details