Only retrieve forms once instead of for every item

[dnwjn]

Hello everyone!

We stumbled upon a bug on /admin/forms. We would get endless loading screens and eventually timeouts when visiting this page. We have quiet an amount of form submissions (~150.000), and the query builder in the current setup retrieves all submissions, with the form for every one of them.

We're using Statamic 5 with this package, and even though we were able to fix this in the FormsController of the statamic/cms package (see statamic/cms#10534), we figured this could still cause problems for other scenarios outside of the FormsController. So we wanted to propose it.

The proposed changes retrieve all forms only once before being connected to each submission, instead of retrieving the form every time. This drastically decreases the amount of queries being executed, and it fixes the timeout issues we were dealing with.

If you have any questions or comments about this, let me know!

[ryanmitchell]

Thanks for the PR!

I would prefer we blink the query result in the Form Repository, similar to how we do it elsewhere (eg collections -

eloquent-driver/src/Collections/CollectionRepository.php

Lines 12 to 26 in 47d3b3a

	public function all(): IlluminateCollection
	{
	return Blink::once('eloquent-collections', function () {
	return $this->transform(app('statamic.eloquent.collections.model')::all());
	});
	}
	public function find($handle): ?CollectionContract
	{
	return Blink::once("eloquent-collection-{$handle}", function () use ($handle) {
	$model = app('statamic.eloquent.collections.model')::whereHandle($handle)->first();
	return $model ? app(CollectionContract::class)->fromModel($model) : null;
	});
	}

)

Do you want to try refactoring it to take that approach and see how it works from a performance perspective on your install?

[dnwjn]

@ryanmitchell Appreciate the quick response! I've implemented Blink, and I'd say it gives about the same results (~6.5 seconds). I see how Blink is more in line with the rest of the package, so let me change that right away!

[ryanmitchell]

I've pushed up some additions to clear the blink cache on save/delete as per the collection repository, and I've also added test coverage as we're trying to get the test suite up to a satisfactory level.

Thanks again for the PR, appreciate you taking the time to submit it.

[dnwjn]

@ryanmitchell Thanks for taking care of this so quickly! If I ever create another PR I'll make sure to take testing into account as well!