[5.x] Blink augmentation of terms and entries fieldtypes #9938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edalzell
reviewed
Apr 19, 2024
edalzell
reviewed
Apr 19, 2024
|
What's the reasoning to not do it for multi-values too? Currently if you have a multi-value entries field type on a page that you access more than once in a template then the query is run each time. If it was blinked, it would only be run once. |
|
Multi-value gives you a query builder. Blinking it isn't gonna do much. It'll still resolve when you use it in templates. |
|
Gotcha, thanks for explaining. Hopefully the augmentation PR makes things less query heavy then. |
This was referenced Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will use blink to prevent unnecessary re-querying on entries and terms fieldtypes when using max_items 1.
On one particular test site, a blog post template a handful of typical taxonomy related bits on the page loaded in about 1.3s. This PR gets it down to about 750ms.