-
-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.x] Add includes
and doesnt_include
conditions and modifiers
#9491
base: 5.x
Are you sure you want to change the base?
[5.x] Add includes
and doesnt_include
conditions and modifiers
#9491
Conversation
includes
condition and modifierincludes
and doesnt_include
conditions and modifiers
includes
and doesnt_include
conditions and modifiersincludes
and doesnt_include
conditions and includes
modifier
Good job! This is very useful and will solve not being able to filter by any field that gets saved by an array (like multiple select, checkboxes etc). |
This is very useful, and seems to work like a charm. I ran into a Statamic limitation and @afonic pointed me to your PR Ryan. Thanks both. |
Jason do you reckon this will make the cut someday and I can patch it in? Otherwise I'll work on a query scope instead. |
More than likely, but not 100% sure. |
Gotcha. Thanks Jason. |
Nice! This will close statamic/ideas#910 |
includes
and doesnt_include
conditions and includes
modifierincludes
and doesnt_include
conditions and includes
modifier
includes
and doesnt_include
conditions and includes
modifierincludes
and doesnt_include
conditions and modifiers
This is a second go at this and is an alternative to / replaces #8357
This PR adds an
includes
modifier and tag condition, as well as adoesnt_include
tag condition. The Modifier is intentionally a loose comparison, so if any of the values in needle are found it counts as a match. This is to mirror howwhereJsonContains()
on the eloquent side.Potentially an
includes_all
modifier could be added for a strict comparison (or the naming of this could be changed toincludes_any
).Closes statamic/ideas#910