Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2144 by fixing an incompatible config array being passed along to reference fields.
We build an array of the field's configs, and when you click a field, that array gets passed up to the server via ajax.
It's preProcessed on the server. The error was happening because we preprocessed it twice - once when building the initial array, and again when it's passed up to the server. Once upon a time, we may have needed it processed up front but looks like it hung around unintentionally when we changed the approach.
The issue was in
toBlueprintArray()
- it was only used in the core in two spots:toBlueprintArray
, I just inlined the appropriate keys needed. It was passing in more than necessary anyway.The name
toBlueprintArray
is unintuitive, so I've deprecated it and just left it alone. Anyone using it (I only see one non-core use on all of GitHub, by @duncanmcclean).